WordPress.org

Make WordPress Core


Ignore:
Timestamp:
06/28/2015 03:26:41 PM (4 years ago)
Author:
jorbin
Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/pomo/entry.php

    r32672 r32990  
    4141     *  - flags (array) -- flags like php-format
    4242     */
    43     function Translation_Entry($args=array()) {
     43    function __construct( $args = array() ) {
    4444        // if no singular -- empty object
    4545        if (!isset($args['singular'])) {
     
    5454        if (!is_array($this->references)) $this->references = array();
    5555        if (!is_array($this->flags)) $this->flags = array();
     56    }
     57
     58    /**
     59     * PHP4 constructor.
     60     */
     61    public function Translation_Entry( $args = array() ) {
     62        self::__construct( $args );
    5663    }
    5764
Note: See TracChangeset for help on using the changeset viewer.