Changeset 33033

Timestamp:

07/01/2015 06:12:04 PM (9 years ago)

Author:

markjaquith

Message:

Slow down on calling zxcvbn if it isn't loaded.

see #32589

Location:

trunk/src/wp-admin

Files:

• js/user-profile.js (modified) (1 diff)
• user-new.php (modified) (1 diff)

trunk/src/wp-admin/js/user-profile.js

@@ -17 +17 @@
         ;
 
-        var generatePassword = function() {
-            pw_field.val( pw_field.data( 'pw' ) );
-            pw_field.trigger( 'propertychange' );
-            pw_field.attr( 'type', 'text' ).focus();
-            pw_field[0].setSelectionRange(100, 100);
+        var generatePassword = window.generatePassword = function() {
+            if ( typeof zxcvbn !== 'function' ) {
+                setTimeout( generatePassword, 50 );
+            } else {
+                pw_field.val( pw_field.data( 'pw' ) );
+                pw_field.trigger( 'propertychange' );
+                pw_field.attr( 'type', 'text' ).focus();
+                pw_field[0].setSelectionRange(100, 100);
+            }
         };
 

trunk/src/wp-admin/user-new.php

@@ -403 +403 @@
             <div class="wp-pwd hide-if-js">
                 <?php $initial_password = wp_generate_password( 24 ); ?>
-                <input type="password" name="pass1" id="pass1" class="regular-text" value="<?php echo esc_attr( $initial_password ); ?>" autocomplete="off" data-reveal="1" data-pw="<?php echo esc_attr( $initial_password ); ?>" />
+                <input type="password" name="pass1" id="pass1" class="regular-text" autocomplete="off" data-reveal="1" data-pw="<?php echo esc_attr( $initial_password ); ?>" />
                 <button type="button" class="button button-secondary wp-hide-pw hide-if-no-js" data-toggle="0">
                     <span class="dashicons dashicons-visibility"></span>