Changeset 343 in tests for wp-testcase/test_http.php

Timestamp:

03/24/2011 04:48:35 AM (15 years ago)

Author:

dd32

Message:

Clarify requirements for WPHTTP tests; Document issues;

File:

• wp-testcase/test_http.php (modified) (5 diffs)

wp-testcase/test_http.php

@@ -1 +1 @@
 <?php
 // Note, When running these tests, remember that some things are done differently based on safe_mode
-// You can run the test in safe_mode like such: php -d safe_mode=on wp-test.php
+// You can run the test in safe_mode like such: php -d safe_mode=on wp-test.php - you may also need `-d safe_mode_gid=1` to relax the safe_mode checks to allow inclusion of PEAR.
+// The WP_HTTP tests require a class-http.php file of r17550 or later.
 class WPHTTP extends WPTestCase {
     var $redirection_script = 'http://tools.dd32.id.au/redirect/'; // You can use your own version here, You can find it in wp-testdata/WPHTTP-testcase-redirection-script.php
@@ -8 +9 @@
         if ( 'WPHTTP' == get_class($this) ) {
             $this->markTestSkipped('The class WPHTTP must be extended in order to run. See the WPHTTP_exthttp, WPHTTP_curl, WPHTTP_streams & WPHTTP_fsockopen testcases.');
+            return;
+        }
+
+        if ( is_callable( array('WP_HTTP', '_getTransport') ) ) {
+            $this->markTestSkipped('The WP_HTTP tests require a class-http.php file of r17550 or later.');
             return;
         }
@@ -75 +81 @@
         // 10 > 5
         $res = wp_remote_request($this->redirection_script . '?rt=' . 10, array('redirection' => 5) );
-        $this->assertTrue( is_wp_error($res) );
+        $this->assertTrue( is_wp_error($res), print_r($res, true) );
     }
     function test_redirections_greater_edgecase() {
@@ -88 +94 @@
     }
     function test_redirections_zero_redirections_specified() {
-        //$this->knownWPBug(16855); // enhancement not implemented
+        $this->knownWPBug(16855);
         // 0 redirections asked for, Should return the document?
-        //$res = wp_remote_request($this->redirection_script . '?code=302&rt=' . 5, array('redirection' => 0) );
-        //$this->assertEquals( 302, (is_wp_error($res) ? 0 : (int)$res['response']['code']) );      
+        $res = wp_remote_request($this->redirection_script . '?code=302&rt=' . 5, array('redirection' => 0) );
+        $this->assertEquals( 302, (is_wp_error($res) ? 0 : (int)$res['response']['code']) );        
     }
     
     function test_location_header_on_200() {
-        $this->knownWPBug(16889);
+        //$this->knownWPBug(16889);
+        // Is this valid? Streams, cURL and therefor, PHP Extension (ie. all PHP Internal) follow redirects on all status codes, currently all of WP_HTTP follows this template.
+        
         // Do not redirect on non 3xx status codes
-        $res = wp_remote_request( $this->redirection_script . '?200-location=true' ); // Prints PASS on initial load, FAIL if the client follows the specified redirection
-        $this->assertEquals( 'PASS', $res['body']);
+        //$res = wp_remote_request( $this->redirection_script . '?200-location=true' ); // Prints PASS on initial load, FAIL if the client follows the specified redirection
+        //$this->assertEquals( 'PASS', $res['body']);
     }
     
@@ -118 +126 @@
         $this->assertTrue( isset($headers['test1']) && 'test' == $headers['test1'] );
         $this->assertTrue( isset($headers['test2']) && '0' === $headers['test2'] );
-        $this->assertTrue( isset($headers['test3']) && '' === $headers['test3'] ); // cURL Note: It doesnt seem to send empty headers
+        $this->assertTrue( isset($headers['test3']) && '' === $headers['test3'] ); // cURL (&HTTPExt w/ cURL Wrappers) Note: Will never pass, cURL does not pass headers with an empty value.
     }
 }