Changeset 34383 for trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

Timestamp:

09/22/2015 06:05:39 AM (11 years ago)

Author:

wonderboymusic

Message:

List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.

Props wonderboymusic, Viper007Bond.
Fixes #21249.

File:

• trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (5 diffs)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -42 +42 @@
                 $page = $this->get_pagenum();
 
-                $this->is_site_themes = ( 'site-themes-network' == $this->screen->id ) ? true : false;
+                $this->is_site_themes = ( 'site-themes-network' === $this->screen->id ) ? true : false;
 
                 if ( $this->is_site_themes )
@@ -146 +146 @@
                         $order = strtoupper( $order );
 
-                        if ( $orderby == 'Name' ) {
-                                if ( 'ASC' == $order )
+                        if ( $orderby === 'Name' ) {
+                                if ( 'ASC' === $order ) {
                                         $this->items = array_reverse( $this->items );
+                                }
                         } else {
                                 uasort( $this->items, array( $this, '_order_callback' ) );
@@ -207 +208 @@
                         return 0;
 
-                if ( 'DESC' == $order )
+                if ( 'DESC' === $order )
                         return ( $a < $b ) ? 1 : -1;
                 else
@@ -297 +298 @@
                                 $status_links[$type] = sprintf( "<a href='%s' %s>%s</a>",
                                         esc_url( add_query_arg('theme_status', $type, $url) ),
-                                        ( $type == $status ) ? ' class="current"' : '',
+                                        ( $type === $status ) ? ' class="current"' : '',
                                         sprintf( $text, number_format_i18n( $count ) )
                                 );
@@ -460 +461 @@
                 global $status, $totals;
                 if ( $theme->errors() ) {
-                        $pre = $status == 'broken' ? __( 'Broken Theme:' ) . ' ' : '';
+                        $pre = $status === 'broken' ? __( 'Broken Theme:' ) . ' ' : '';
                         echo '<p><strong class="error-message">' . $pre . $theme->errors()->get_error_message() . '</strong></p>';
                 }