Changeset 34383 for trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

Timestamp:

09/22/2015 06:05:39 AM (10 years ago)

Author:

wonderboymusic

Message:

List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.

Props wonderboymusic, Viper007Bond.
Fixes #21249.

File:

• trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -78 +78 @@
         $tabs = array();
 
-        if ( 'search' == $tab )
+        if ( 'search' === $tab ) {
             $tabs['search'] = __( 'Search Results' );
+        }
         $tabs['featured']  = _x( 'Featured', 'Plugin Installer' );
         $tabs['popular']   = _x( 'Popular', 'Plugin Installer' );
@@ -239 +240 @@
         $display_tabs = array();
         foreach ( (array) $tabs as $action => $text ) {
-            $class = ( $action == $tab ) ? ' current' : '';
+            $class = ( $action === $tab ) ? ' current' : '';
             $href = self_admin_url('plugin-install.php?tab=' . $action);
             $display_tabs['plugin-install-'.$action] = "<a href='$href' class='$class'>$text</a>";
@@ -311 +312 @@
         }
 
-        if ( 'top' ==  $which ) {
+        if ( 'top' === $which ) {
             wp_referer_field();
         ?>
@@ -368 +369 @@
         }
 
-        if ( 'DESC' == $this->order ) {
+        if ( 'DESC' === $this->order ) {
             return ( $a < $b ) ? 1 : -1;
         } else {