Changeset 34583

Timestamp:

09/26/2015 06:40:39 AM (9 years ago)

Author:

wonderboymusic

Message:

Comments: add __get() and __set() to WP_Comment to provide BC for plugins that are grabbing post properties from the comment object due to an (unintended?) side effect of JOINing with the posts table in WP_Comment_Query, see [17667]. 'fields' used to default to *, so the JOIN would grab every field from both tables. #YOLO

Since [34310], these properties no longer exist. We can lazy load them for plugins with the magic methods.

Fixes #27571.

File:

• trunk/src/wp-includes/class-wp-comment.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-comment.php

@@ -321 +321 @@
         return false;
     }
+
+    /**
+     * Whether a comment has post from which to retrieve magic properties
+     *
+     * @since 4.4.0
+     * @access public
+     *
+     * @param string $name
+     * @return bool
+     */
+    public function __isset( $name ) {
+        if (
+            0 === (int) $this->comment_post_ID
+            || property_exists( $this, $name )
+        ) {
+            return;
+        }
+
+        $post = get_post( $this->comment_post_ID );
+        if ( $post ) {
+            return property_exists( $post, $name );
+        }
+    }
+
+    /**
+     * Magic getter for $post properties
+     *
+     * @since 4.4.0
+     * @access public
+     *
+     * @param string $name
+     * @return mixed
+     */
+    public function __get( $name ) {
+        $post = get_post( $this->comment_post_ID );
+        if ( $post ) {
+            return $post->$name;
+        }
+    }
 }