Changeset 36216 for trunk/src/wp-includes/class-wp-customize-manager.php

Timestamp:

01/07/2016 06:05:07 AM (8 years ago)

Author:

westonruter

Message:

Customizer: Call _doing_it_wrong() if widgets or nav_menus are manually removed via WP_Customize_Manager::remove_panel().

Advise that the customize_loaded_components filter should be used instead.

Props voldemortensen.
See #33552.
Fixes #35242.

File:

• trunk/src/wp-includes/class-wp-customize-manager.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-customize-manager.php

@@ -1199 +1199 @@
      */
     public function remove_panel( $id ) {
+        $core_panels = array(
+            'widgets',
+            'nav_menus',
+        );
+        if ( in_array( $id, $core_panels, true ) ) {
+            $url = 'https://core.trac.wordpress.org/ticket/33552#comment:12';
+            _doing_it_wrong(
+                __METHOD__,
+                sprintf( __( 'Removing %1$s manually will cause PHP warnings. Use the <code>customize_loaded_components</code> filter instead. See <a href="%2$s">%2$s</a>.' ), $id, $url ),
+                '4.5'
+            );
+        }
         unset( $this->panels[ $id ] );
     }