Changeset 36584 for trunk/src/wp-admin/includes/post.php

Timestamp:

02/19/2016 03:09:51 PM (9 years ago)

Author:

afercia

Message:

Accessibility: after [36000] conditionally print out the aria-describedby attribute on the Featured Image postbox.

Fixes #35076.

File:

• trunk/src/wp-admin/includes/post.php (modified) (2 diffs)

trunk/src/wp-admin/includes/post.php

@@ -1381 +1381 @@
     $post               = get_post( $post );
     $post_type_object   = get_post_type_object( $post->post_type );
-    $set_thumbnail_link = '<p class="hide-if-no-js"><a href="%s" id="set-post-thumbnail" aria-describedby="set-post-thumbnail-desc" class="thickbox">%s</a></p>';
+    $set_thumbnail_link = '<p class="hide-if-no-js"><a href="%s" id="set-post-thumbnail"%s class="thickbox">%s</a></p>';
     $upload_iframe_src  = get_upload_iframe_src( 'image', $post->ID );
 
     $content = sprintf( $set_thumbnail_link,
         esc_url( $upload_iframe_src ),
+        '', // Empty when there's no featured image set, `aria-describedby` attribute otherwise.
         esc_html( $post_type_object->labels->set_featured_image )
     );
@@ -1417 +1418 @@
             $content = sprintf( $set_thumbnail_link,
                 esc_url( $upload_iframe_src ),
+                ' aria-describedby="set-post-thumbnail-desc"',
                 $thumbnail_html
             );