Changeset 36964 for trunk/src/wp-admin/includes/dashboard.php

Timestamp:

03/10/2016 10:36:25 PM (9 years ago)

Author:

afercia

Message:

Accessibility: Improve accessibility for the Plugin details modal.

The plugin details modal can be invoked from several screens. There's now a new
.open-plugin-details-modal CSS class to be used in combination with the
.thickbox CSS class that adds everything needed for accessibility.

• Adds an ARIA role dialog and an aria-label attribute to the modal
• Adds a title attribute to the iframe inside the modal
• Constrains tabbing within the modal
• Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (1 diff)

trunk/src/wp-admin/includes/dashboard.php

@@ -1246 +1246 @@
         $ilink = wp_nonce_url('plugin-install.php?tab=plugin-information&plugin=' . $slug, 'install-plugin_' . $slug) . '&TB_iframe=true&width=600&height=800';
         echo '<li class="dashboard-news-plugin"><span>' . __( 'Popular Plugin' ) . ':</span> ' . esc_html( $raw_title ) .
-            '&nbsp;<a href="' . $ilink . '" class="thickbox" aria-label="' .
+            '&nbsp;<a href="' . $ilink . '" class="thickbox open-plugin-details-modal" aria-label="' .
             /* translators: %s: plugin name */
             esc_attr( sprintf( __( 'Install %s' ), $raw_title ) ) . '">(' . __( 'Install' ) . ')</a></li>';