Changeset 37785

Timestamp:

06/21/2016 02:22:35 PM (8 years ago)

Author:

nbachiyski

Message:

Admin: Escape attachment name in case it contains special characters

Merge of [37774] to the 4.4 branch.

Location:

branches/4.4/src

Files:

• wp-admin/includes/class-wp-media-list-table.php (modified) (1 diff)
• wp-includes/post-template.php (modified) (1 diff)

branches/4.4/src/wp-admin/includes/class-wp-media-list-table.php

@@ -393 +393 @@
             <?php
             $file = get_attached_file( $post->ID );
-            echo wp_basename( $file );
+            echo esc_html( wp_basename( $file ) );
             ?>
         </p>

branches/4.4/src/wp-includes/post-template.php

@@ -1448 +1448 @@
      * @param string|bool  $text      If string, will be link text. Default false.
      */
-    return apply_filters( 'wp_get_attachment_link', "<a href='$url'>$link_text</a>", $id, $size, $permalink, $icon, $text );
+    return apply_filters( 'wp_get_attachment_link', "<a href='" . esc_url( $url ) . "'>$link_text</a>", $id, $size, $permalink, $icon, $text );
 }