Changeset 38971

Timestamp:

10/26/2016 10:19:08 PM (8 years ago)

Author:

rachelbaker

Message:

REST API: Add the default_comment_status and default_ping_status options to the setting endpoint.

Props joehoyle.
See #38490.

Location:

trunk

Files:

• src/wp-includes/option.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-settings-controller.php (modified) (2 diffs)

trunk/src/wp-includes/option.php

@@ -1820 +1820 @@
         'default'      => 10,
     ) );
+
+    register_setting( 'discussion', 'default_ping_status', array(
+        'show_in_rest' => array(
+            'schema'   => array(
+                'enum' => array( 'open', 'closed' ),
+            ),
+        ),
+        'type'         => 'string',
+        'description'  => __( 'Allow link notifications from other blogs (pingbacks and trackbacks) on new articles.' ),
+    ) );
+
+    register_setting( 'discussion', 'default_comment_status', array(
+        'show_in_rest' => array(
+            'schema'   => array(
+                'enum' => array( 'open', 'closed' ),
+            ),
+        ),
+        'type'         => 'string',
+        'description'  => __( 'Allow people to post comments on new articles.' ),
+    ) );
+
 }
 

trunk/tests/phpunit/tests/rest-api/rest-settings-controller.php

@@ -58 +58 @@
             'default_post_format',
             'posts_per_page',
+            'default_ping_status',
+            'default_comment_status',
         ), array_keys( $data ) );
     }
@@ -229 +231 @@
     }
 
+    public function test_update_item_with_invalid_enum() {
+        update_option( 'posts_per_page', 9 );
+
+        wp_set_current_user( $this->administrator );
+        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
+        $request->set_param( 'default_ping_status', 'open&closed' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+    }
+
     public function test_delete_item() {
     }