Changeset 38972

Timestamp:

10/26/2016 10:37:35 PM (10 years ago)

Author:

westonruter

Message:

Customize: Remove unnecessary code for edit shortcuts which is no longer required due to moving buttons inside of partial placement containers.

Props sirbrillig.
Amends [38967].
See #27403.

Location:

trunk/src/wp-includes

Files:

• css/customize-preview.css (modified) (1 diff)
• js/customize-selective-refresh.js (modified) (1 diff)

trunk/src/wp-includes/css/customize-preview.css

@@ -93 +93 @@
 }
 
-.widget button.customize-partial-edit-shortcut-absolute,
-.customize-partial-edit-shortcut-absolute {
-        position: static;
-}
-
 .customize-partial-edit-shortcut-left-margin:before {
         left: 0;

trunk/src/wp-includes/js/customize-selective-refresh.js

@@ -142 +142 @@
                         $placementContainer = $( placement.container );
                         $placementContainer.prepend( $editShortcut );
-                        if ( 'absolute' === $placementContainer.css( 'position' ) ) {
-                                $editShortcut.addClass( 'customize-partial-edit-shortcut-absolute' );
-                                $editShortcut.css( partial.getEditShortcutPositionStyles( $placementContainer ) );
-                                partial.whenPageChanges( function() {
-                                        $editShortcut.css( partial.getEditShortcutPositionStyles( $placementContainer ) );
-                                } );
-                        }
                         if ( ! $placementContainer.is( ':visible' ) || 'none' === $placementContainer.css( 'display' ) ) {
                                 $editShortcut.addClass( 'customize-partial-edit-shortcut-hidden' );
                         }
                         $editShortcut.toggleClass( 'customize-partial-edit-shortcut-left-margin', $editShortcut.offset().left < 1 );
-                },
-
-                /**
-                 * Call a callback function when the page changes.
-                 *
-                 * This calls a callback for any change that might require refreshing the edit shortcuts.
-                 *
-                 * @since 4.7
-                 *
-                 * @param {Function} callback The function to call when the page changes.
-                 * @returns {void}
-                 */
-                whenPageChanges: function( callback ) {
-                        var debouncedCallback, $document;
-                        debouncedCallback = _.debounce( function() {
-                                // Timeout allows any page animations to finish
-                                setTimeout( callback, 100 );
-                        }, 350 );
-                        // When window is resized.
-                        $( window ).resize( debouncedCallback );
-                        // When any customizer setting changes.
-                        api.bind( 'change', debouncedCallback );
-                        $document = $( window.document );
-                        // After scroll in case there are fixed position elements
-                        $document.on( 'scroll', debouncedCallback );
-                        // After page click (eg: hamburger menus)
-                        $document.on( 'click', debouncedCallback );
-                },
-
-                /**
-                 * Return the CSS positioning for the edit shortcut for a given partial placement.
-                 *
-                 * @since 4.7
-                 *
-                 * @param {jQuery} $placementContainer The placement container element as a jQuery object.
-                 * @return {Object} Object containing CSS positions.
-                 */
-                getEditShortcutPositionStyles: function( $placementContainer ) {
-                        return {
-                                top: $placementContainer.css( 'top' ),
-                                left: $placementContainer.css( 'left' ),
-                                right: 'auto'
-                        };
                 },