Changeset 39105 for trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

Timestamp:

11/03/2016 02:17:39 AM (8 years ago)

Author:

rachelbaker

Message:

REST API: Clean-up our validation callbacks and add missing array items properties in our endpoint schemas.

Props joehoyle, jnylen0.
Fixes #38617.

File:

• trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (11 diffs)

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -301 +301 @@
         $this->assertEquals( 2, count( $data ) );
         $this->assertEquals( $id3, $data[0]['id'] );
+        // Orderby=>invalid should fail.
+        $request->set_param( 'orderby', 'invalid' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+        // fails on invalid id.
+        $request->set_param( 'orderby', array( 'include' ) );
+        $request->set_param( 'include', array( 'invalid' ) );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -321 +330 @@
         $this->assertTrue( in_array( $id1, wp_list_pluck( $data, 'id' ), true ) );
         $this->assertFalse( in_array( $id2, wp_list_pluck( $data, 'id' ), true ) );
+
+        // fails on invalid id.
+        $request->set_param( 'exclude', array( 'invalid' ) );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -344 +358 @@
         $response = $this->server->dispatch( $request );
         $this->assertCount( 2, $response->get_data() );
+        // 'offset' with invalid value errors.
+        $request->set_param( 'offset', 'moreplease' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -365 +383 @@
         $data = $response->get_data();
         $this->assertEquals( self::$approved_id, $data[0]['id'] );
+        // order=>asc,id should fail
+        $request->set_param( 'order', 'asc,id' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -403 +425 @@
         $comments = $response->get_data();
         $this->assertCount( 2, $comments );
+        // Invalid author param errors
+        $request->set_param( 'author', 'skippy' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
         // Unavailable to unauthenticated; defaults to error
         wp_set_current_user( 0 );
+        $request->set_param( 'author', array( self::$author_id, self::$subscriber_id ) );
         $response = $this->server->dispatch( $request );
         $this->assertErrorResponse( 'rest_forbidden_param', $response, 401 );
@@ -442 +469 @@
         $comments = $response->get_data();
         $this->assertCount( 2, $comments );
+        // 'author_exclude' for both invalid author
+        $request = new WP_REST_Request( 'GET', '/wp/v2/comments' );
+        $request->set_param( 'author_exclude', 'skippy' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
         // Unavailable to unauthenticated; defaults to error
         wp_set_current_user( 0 );
+        $request->set_param( 'author_exclude', array( self::$author_id, self::$subscriber_id ) );
         $response = $this->server->dispatch( $request );
         $this->assertErrorResponse( 'rest_forbidden_param', $response, 401 );
@@ -471 +504 @@
         $response = $this->server->dispatch( $request );
         $this->assertCount( 2, $response->get_data() );
+        // Invalid parent should error
+        $request->set_param( 'parent', 'invalid' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -496 +533 @@
         $response = $this->server->dispatch( $request );
         $this->assertCount( 3, $response->get_data() );
+        // Invalid parent id should error
+        $request->set_param( 'parent_exclude', 'invalid' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -958 +999 @@
     }
 
+    public function test_create_comment_invalid_email() {
+        $post_id = $this->factory->post->create();
+        wp_set_current_user( self::$admin_id );
+
+        $params = array(
+            'post'  => $post_id,
+            'author'       => self::$admin_id,
+            'author_name'  => 'Comic Book Guy',
+            'author_email' => 'hello:)',
+            'author_url'   => 'http://androidsdungeon.com',
+            'content' => 'Worst Comment Ever!',
+            'date'  => '2014-11-07T10:14:25',
+        );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/comments' );
+        $request->add_header( 'content-type', 'application/json' );
+        $request->set_body( wp_json_encode( $params ) );
+
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+    }
+
     public function test_create_item_current_user() {
         $user_id = $this->factory->user->create( array(
@@ -1056 +1119 @@
 
         $this->assertErrorResponse( 'rest_comment_invalid_karma', $response, 403 );
+    }
+
+    public function test_create_comment_invalid_post() {
+        wp_set_current_user( self::$subscriber_id );
+
+        $params = array(
+            'post'         => 'some-slug',
+            'author_name'  => 'Homer Jay Simpson',
+            'author_email' => 'chunkylover53@aol.com',
+            'author_url'   => 'http://compuglobalhypermeganet.com',
+            'content'      => 'Here\’s to alcohol: the cause of, and solution to, all of life\’s problems.',
+            'author'       => self::$subscriber_id,
+        );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/comments' );
+        $request->add_header( 'content-type', 'application/json' );
+        $request->set_body( wp_json_encode( $params ) );
+        $response = $this->server->dispatch( $request );
+
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+    }
+
+    public function test_create_comment_karma_invalid_value() {
+        wp_set_current_user( self::$subscriber_id );
+
+        $params = array(
+            'post'       => self::$post_id,
+            'author_name'  => 'Homer Jay Simpson',
+            'author_email' => 'chunkylover53@aol.com',
+            'author_url'   => 'http://compuglobalhypermeganet.com',
+            'content'     => 'Here\’s to alcohol: the cause of, and solution to, all of life\’s problems.',
+            'author'       => self::$subscriber_id,
+            'karma'     => 'themostkarmaever',
+        );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/comments' );
+        $request->add_header( 'content-type', 'application/json' );
+        $request->set_body( wp_json_encode( $params ) );
+        $response = $this->server->dispatch( $request );
+
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -1894 +1998 @@
         $this->assertArrayHasKey( 'status', $properties );
         $this->assertArrayHasKey( 'type', $properties );
+
+        $this->assertEquals( '127.0.0.1', $properties['author_ip']['default'] );
+        $this->assertEquals( 0, $properties['parent']['default'] );
+        $this->assertEquals( 0, $properties['post']['default'] );
     }