Changeset 39663 for trunk/src/wp-includes/comment.php

Timestamp:

01/02/2017 07:58:09 PM (8 years ago)

Author:

boonebgorges

Message:

Ignore the 'comment_order' setting when determining comment pagination.

[38740] incorrectly introduced logic that changed a comment's page when
'comment_order' was set to 'desc'. This is in violation of the design
of the comment pagination system: a comment's page is designed not to
change when 'comment_order' or 'default_comment_page' are changed.
See #31101.

Props rachelbaker.
Fixes #39280.

File:

• trunk/src/wp-includes/comment.php (modified) (2 diffs)

trunk/src/wp-includes/comment.php

@@ -1004 +1004 @@
             return get_page_of_comment( $comment->comment_parent, $args );
 
-        if ( 'desc' === get_option( 'comment_order' ) ) {
-            $compare = 'after';
-        } else {
-            $compare = 'before';
-        }
-
         $comment_args = array(
             'type'       => $args['type'],
@@ -1020 +1014 @@
                 array(
                     'column' => "$wpdb->comments.comment_date_gmt",
-                    $compare => $comment->comment_date_gmt,
+                    'before' => $comment->comment_date_gmt,
                 )
             ),