Changeset 40123 for trunk/tests/phpunit/tests/image/editor_imagick.php

Timestamp:

02/25/2017 05:25:40 AM (8 years ago)

Author:

mikeschroder

Message:

Media: Reset Exif orientation after rotate in WP_Image_Editor_Imagick.

Due to inconsistencies in the way browsers handle Exif orientation data,
if a user manually rotates an image within WordPress, set the Exif orientation to
the default (1) so that the image displays with the same rotation/flip in every browser.

Props sanchothefat, triplejumper12, joemcgill, azaozz, markoheijnen, mikeschroder.
See #14459.
Fixes #37140.

File:

• trunk/tests/phpunit/tests/image/editor_imagick.php (modified) (1 diff)

trunk/tests/phpunit/tests/image/editor_imagick.php

@@ -543 +543 @@
         $this->assertTrue( $result );
     }
+
+    /**
+     * Test resetting Exif orientation data on rotate
+     *
+     * @ticket 37140
+     */
+    public function test_remove_orientation_data_on_rotate() {
+        $file = DIR_TESTDATA . "/images/test-image-upside-down.jpg";
+        $data = wp_read_image_metadata( $file );
+
+        // The orientation value 3 is equivalent to rotated upside down (180 degrees).
+        $this->assertEquals( 3, intval( $data['orientation'] ), 'Orientation value read from does not match image file Exif data: ' . $file );
+
+        $temp_file = wp_tempnam( $file );
+        $image = wp_get_image_editor( $file );
+
+        // Test a value that would not lead back to 1, as WP is resetting the value to 1 manually.
+        $image->rotate( 90 );
+        $ret = $image->save( $temp_file, 'image/jpeg' );
+
+        $data = wp_read_image_metadata( $ret['path'] );
+
+        // Make sure the image is no longer in The Upside Down Exif orientation.
+        $this->assertEquals( 1, intval( $data['orientation'] ), 'Orientation Exif data was not updated after rotating image: ' . $file );
+
+        // Remove both the generated file ending in .tmp and tmp.jpg due to wp_tempnam().
+        unlink( $temp_file );
+        unlink( $ret['path'] );
+    }
+
 }