Changeset 41507 for branches/3.8/src/wp-includes/wp-db.php

Timestamp:

09/19/2017 06:43:47 PM (9 years ago)

Author:

aaroncampbell

Message:

Database: Hardening to bring wpdb::prepare() inline with documentation.

wpdb::prepare() supports %s, %d, and %F as placeholders in the query string. Any other non-escaped % will be escaped.

Merges [41496] to 3.8 branch.

Location:

branches/3.8

Files:

• . (modified) (1 prop)
• src/wp-includes/wp-db.php (modified) (1 diff)

branches/3.8/src/wp-includes/wp-db.php

@@ -1057 +1057 @@
         $query = preg_replace( '|(?<!%)%f|' , '%F', $query ); // Force floats to be locale unaware
         $query = preg_replace( '|(?<!%)%s|', "'%s'", $query ); // quote the strings, avoiding escaped strings like %%s
+        $query = preg_replace( '/%(?:%|$|([^dsF]))/', '%%\\1', $query ); // escape any unescaped percents 
         array_walk( $args, array( $this, 'escape_by_ref' ) );
         return @vsprintf( $query, $args );