Changeset 41670 for trunk/src/wp-includes/class-wp-customize-nav-menus.php

Timestamp:

10/02/2017 04:11:50 AM (7 years ago)

Author:

westonruter

Message:

Customize: Fix WP_Customize_Date_Time_Control to be re-usable for plugins and custom settings.

• Allow time fields to be omitted by constructing with timeIncluded as false.
• Ensure reportValidity is only called on a control when it is in an expanded section.
• Rename "ampm" to "meridian".
• Improve accessibility and fix HTML validation and style issues for both the date/time control and the preview link control.
• Fix styling of dropdowns and clean CSS.
• Improve accessibility of nav menus component.

Props westonruter, afercia, sayedwp, melchoyce.
Amends [41626].
See #39896.
Fixes #42022.

File:

• trunk/src/wp-includes/class-wp-customize-nav-menus.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-customize-nav-menus.php

@@ -675 +675 @@
 
         $this->manager->add_control( 'new_menu_name', array(
-            'label'       => '',
+            'label'       => __( 'New menu name' ),
             'section'     => 'add_menu',
             'type'        => 'text',
@@ -681 +681 @@
             'input_attrs' => array(
                 'class'       => 'menu-name-field',
-                'placeholder' => __( 'New menu name' ),
             ),
         ) );
@@ -1018 +1017 @@
                     <?php if ( current_user_can( $post_type_obj->cap->create_posts ) && current_user_can( $post_type_obj->cap->publish_posts ) ) : ?>
                         <div class="new-content-item">
-                            <input type="text" class="create-item-input" placeholder="<?php echo esc_attr( $post_type_obj->labels->add_new_item ); ?>">
+                            <label for="<?php echo esc_attr( 'create-item-input-' . $available_item_type['object'] ); ?>" class="screen-reader-text"><?php echo esc_html( $post_type_obj->labels->add_new_item ); ?></label>
+                            <input type="text" id="<?php echo esc_attr( 'create-item-input-' . $available_item_type['object'] ); ?>" class="create-item-input" placeholder="<?php echo esc_attr( $post_type_obj->labels->add_new_item ); ?>">
                             <button type="button" class="button add-content"><?php _e( 'Add' ); ?></button>
                         </div>