Changeset 42343 for trunk/src/wp-admin/includes/class-bulk-theme-upgrader-skin.php

Timestamp:

11/30/2017 11:09:33 PM (6 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-admin/includes/class-bulk-theme-upgrader-skin.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-bulk-theme-upgrader-skin.php

@@ -21 +21 @@
     public function add_strings() {
         parent::add_strings();
-        $this->upgrader->strings['skin_before_update_header'] = __('Updating Theme %1$s (%2$d/%3$d)');
+        $this->upgrader->strings['skin_before_update_header'] = __( 'Updating Theme %1$s (%2$d/%3$d)' );
     }
 
     /**
-     *
      * @param string $title
      */
-    public function before($title = '') {
-        parent::before( $this->theme_info->display('Name') );
+    public function before( $title = '' ) {
+        parent::before( $this->theme_info->display( 'Name' ) );
     }
 
     /**
-     *
      * @param string $title
      */
-    public function after($title = '') {
-        parent::after( $this->theme_info->display('Name') );
+    public function after( $title = '' ) {
+        parent::after( $this->theme_info->display( 'Name' ) );
         $this->decrement_update_count( 'theme' );
     }
@@ -45 +43 @@
     public function bulk_footer() {
         parent::bulk_footer();
-        $update_actions =  array(
-            'themes_page' => '<a href="' . self_admin_url( 'themes.php' ) . '" target="_parent">' . __( 'Return to Themes page' ) . '</a>',
-            'updates_page' => '<a href="' . self_admin_url( 'update-core.php' ) . '" target="_parent">' . __( 'Return to WordPress Updates page' ) . '</a>'
+        $update_actions = array(
+            'themes_page'  => '<a href="' . self_admin_url( 'themes.php' ) . '" target="_parent">' . __( 'Return to Themes page' ) . '</a>',
+            'updates_page' => '<a href="' . self_admin_url( 'update-core.php' ) . '" target="_parent">' . __( 'Return to WordPress Updates page' ) . '</a>',
         );
-        if ( ! current_user_can( 'switch_themes' ) && ! current_user_can( 'edit_theme_options' ) )
+        if ( ! current_user_can( 'switch_themes' ) && ! current_user_can( 'edit_theme_options' ) ) {
             unset( $update_actions['themes_page'] );
+        }
 
         /**
@@ -62 +61 @@
         $update_actions = apply_filters( 'update_bulk_theme_complete_actions', $update_actions, $this->theme_info );
 
-        if ( ! empty($update_actions) )
-            $this->feedback(implode(' | ', (array)$update_actions));
+        if ( ! empty( $update_actions ) ) {
+            $this->feedback( implode( ' | ', (array) $update_actions ) );
+        }
     }
 }