Changeset 43154 for trunk/src/wp-includes/comment.php

Timestamp:

05/03/2018 07:27:14 PM (7 years ago)

Author:

iandunn

Message:

Privacy: Store plugin callbacks in associative array for flexibility.

The personal data export and erasure tools allow plugins to register their own callbacks, in order to add additional data to the export and erasure processes. Previously, these were registered without specifying a constant identifier in the array of callbacks. Using mutable integers makes it difficult for plugins to modify the callbacks of other plugins, though.

Using associative array keys instead provides a covenient and reliable way to identify and interact with another plugin's callbacks.

Props desrosj, allendav, ocean90.
Fixes #43931.

File:

• trunk/src/wp-includes/comment.php (modified) (3 diffs)

trunk/src/wp-includes/comment.php

@@ -3286 +3286 @@
  */
 function wp_register_comment_personal_data_exporter( $exporters ) {
-    $exporters[] = array(
+    $exporters['wordpress-comments'] = array(
         'exporter_friendly_name' => __( 'WordPress Comments' ),
         'callback'               => 'wp_comments_personal_data_exporter',
@@ -3391 +3391 @@
  */
 function wp_register_comment_personal_data_eraser( $erasers ) {
-    $erasers[] = array(
+    $erasers['wordpress-comments'] = array(
         'eraser_friendly_name' => __( 'WordPress Comments' ),
         'callback'             => 'wp_comments_personal_data_eraser',
@@ -3499 +3499 @@
     );
 }
-