Changeset 43571 for trunk/src/wp-admin/includes/class-wp-media-list-table.php

Timestamp:

08/17/2018 01:50:26 AM (8 years ago)

Author:

pento

Message:

Coding Standards: Upgrade WPCS to 1.0.0

WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:

• Multiline function calls must now put each parameter on a new line.
• Auto-formatting files is now part of the grunt precommit script.
• Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.

File:

• trunk/src/wp-admin/includes/class-wp-media-list-table.php (modified) (10 diffs)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -172 +172 @@
                         return;
                 }
-?>
+                ?>
                 <div class="actions">
-<?php
-if ( ! is_singular() ) {
-        if ( ! $this->is_trash ) {
-                $this->months_dropdown( 'attachment' );
-        }
-
-        /** This action is documented in wp-admin/includes/class-wp-posts-list-table.php */
-        do_action( 'restrict_manage_posts', $this->screen->post_type, $which );
-
-        submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
-}
-
-if ( $this->is_trash && current_user_can( 'edit_others_posts' ) && $this->has_items() ) {
-        submit_button( __( 'Empty Trash' ), 'apply', 'delete_all', false );
-}
+                <?php
+                if ( ! is_singular() ) {
+                        if ( ! $this->is_trash ) {
+                                $this->months_dropdown( 'attachment' );
+                        }
+
+                        /** This action is documented in wp-admin/includes/class-wp-posts-list-table.php */
+                        do_action( 'restrict_manage_posts', $this->screen->post_type, $which );
+
+                        submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
+                }
+
+                if ( $this->is_trash && current_user_can( 'edit_others_posts' ) && $this->has_items() ) {
+                        submit_button( __( 'Empty Trash' ), 'apply', 'delete_all', false );
+                }
                 ?>
                 </div>
-<?php
+                <?php
         }
 
@@ -237 +237 @@
 
                 $this->screen->render_screen_reader_content( 'heading_views' );
-?>
+                ?>
 <div class="wp-filter">
         <div class="filter-items">
@@ -253 +253 @@
                 </select>
 
-<?php
+                <?php
                 $this->extra_tablenav( 'bar' );
 
@@ -260 +260 @@
 
                 // Back compat for pre-4.0 view links.
-if ( ! empty( $views ) ) {
-        echo '<ul class="filter-links">';
-        foreach ( $views as $class => $view ) {
-                echo "<li class='$class'>$view</li>";
-        }
-        echo '</ul>';
-}
-?>
+                if ( ! empty( $views ) ) {
+                        echo '<ul class="filter-links">';
+                        foreach ( $views as $class => $view ) {
+                                echo "<li class='$class'>$view</li>";
+                        }
+                        echo '</ul>';
+                }
+                ?>
         </div>
 
@@ -274 +274 @@
                 <input type="search" placeholder="<?php esc_attr_e( 'Search media items...' ); ?>" id="media-search-input" class="search" name="s" value="<?php _admin_search_query(); ?>"></div>
         </div>
-        <?php
+                <?php
         }
 
@@ -355 +355 @@
         public function column_cb( $post ) {
                 if ( current_user_can( 'edit_post', $post->ID ) ) {
-                ?>
+                        ?>
                         <label class="screen-reader-text" for="cb-select-<?php echo $post->ID; ?>">
                                                                                                                                                 <?php
                                                                                                                                                 echo sprintf( __( 'Select %s' ), _draft_or_post_title() );
-                        ?>
+                                                                                                                                                ?>
                         </label>
                         <input type="checkbox" name="media[]" id="cb-select-<?php echo $post->ID; ?>" value="<?php echo $post->ID; ?>" />
-                <?php
+                        <?php
                 }
         }
@@ -396 +396 @@
                         echo $link_start;
                         if ( $thumb ) :
-                        ?>
+                                ?>
                                 <span class="media-icon <?php echo sanitize_html_class( $mime . '-icon' ); ?>"><?php echo $thumb; ?></span>
-                        <?php
+                                <?php
                         endif;
                         echo $title . $link_end;
@@ -488 +488 @@
 
                         if ( $parent_type && $parent_type->show_ui && current_user_can( 'edit_post', $post->post_parent ) ) {
-?>
+                                ?>
                                 <strong><a href="<?php echo get_edit_post_link( $post->post_parent ); ?>">
                                         <?php echo $title; ?></a></strong>
                                                                 <?php
                         } elseif ( $parent_type && current_user_can( 'read_post', $post->post_parent ) ) {
-?>
+                                ?>
                                 <strong><?php echo $title; ?></strong>
                                                                         <?php
@@ -506 +506 @@
                                                 'media[]'        => $post->ID,
                                                 '_wpnonce'       => wp_create_nonce( 'bulk-' . $this->_args['plural'] ),
-                                        ), 'upload.php'
+                                        ),
+                                        'upload.php'
                                 );
                                 printf(
@@ -632 +633 @@
                         }
                         $post_owner = ( get_current_user_id() == $post->post_author ) ? 'self' : 'other';
-                ?>
+                        ?>
                         <tr id="post-<?php echo $post->ID; ?>" class="<?php echo trim( ' author-' . $post_owner . ' status-' . $post->post_status ); ?>">
                                 <?php $this->single_row_columns( $post ); ?>
                         </tr>
-                <?php
+                        <?php
                 endwhile;
         }