Changeset 44185

Timestamp:

12/14/2018 04:31:30 PM (6 years ago)

Author:

desrosj

Message:

PHP 7.3 Compatibility: Fix compact related notices.

In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. This fixes a few more instances of unset variables in the WordPress admin.

The full RFC can be viewed here: ​https://wiki.php.net/rfc/compact.

See #44416.
Fixes #45483.

Location:

branches/5.0/src/wp-admin/includes

Files:

• plugin-install.php (modified) (1 diff)
• post.php (modified) (3 diffs)

branches/5.0/src/wp-admin/includes/plugin-install.php

@@ -395 +395 @@
     $url = false;
     $update_file = false;
+    $version = '';
 
     /*

branches/5.0/src/wp-admin/includes/post.php

@@ -1030 +1030 @@
 
     $avail_post_stati = get_available_post_statuses($post_type);
+    $post_status      = '';
+    $perm             = '';
 
     if ( isset($q['post_status']) && in_array( $q['post_status'], $post_stati ) ) {
@@ -1035 +1037 @@
         $perm = 'readable';
     }
+
+    $orderby = '';
 
     if ( isset( $q['orderby'] ) ) {
@@ -1041 +1045 @@
         $orderby = 'modified';
     }
+
+    $order = '';
 
     if ( isset( $q['order'] ) ) {