Post edit and Add New Plugin pages have PHP notices in 7.3.

[desrosj]

The post edit pages (wp-admin/edit.php) and Add New Plugin pages have PHP notices in PHP 7.3.

These are caused by missing variables when compact() is called in wp_edit_posts_query() and install_plugin_install_status().

Related: #44416.

[DrewAPicture]

Seems like this should ship with 5.0 considering PHP 7.3 compat is a headline feature. @pento thoughts?

[desrosj]

@DrewAPicture see https://core.trac.wordpress.org/ticket/44416#comment:22

[ocean90]

#45523 was marked as a duplicate.

[ocean90]

#45587 was marked as a duplicate.

[spacedmonkey]

Related #45582

[desrosj]

In 44185:

PHP 7.3 Compatibility: Fix compact related notices.

In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. This fixes a few more instances of unset variables in the WordPress admin.

The full RFC can be viewed here: ​https://wiki.php.net/rfc/compact.

See #44416.
Fixes #45483.

[desrosj]

Reopening for merge into trunk.

[desrosj]

In 44297:

PHP 7.3 Compatibility: Fix compact related notices.

In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. This fixes a few more instances of unset variables in the WordPress admin.

The full RFC can be viewed here: ​https://wiki.php.net/rfc/compact.

See #44416.

Merges [44185] into trunk.

Fixes #45483.

[pcarvalho]

this won't be merged to 4.9.x?

don't really understand the info here:
https://core.trac.wordpress.org/changeset/44297

Property svn:mergeinfo changed
/branches/5.0	merged: 44185	

should this have something like?

/branches/3.1	merged	eligible
/branches/3.3	merged	eligible
/branches/3.4	merged	eligible
/branches/4.9	merged	eligible
/branches/5.0	merged	eligible