Changeset 44796 for trunk/src/wp-includes/customize/class-wp-customize-media-control.php

Timestamp:

03/05/2019 05:49:00 PM (5 years ago)

Author:

afercia

Message:

Accessibility: Replace media placeholder clickable divs with buttons.

<button> elements are natively interactive, supported by any assistive technology, and must be used instead of non-semantic, non-accessible <div> elements.

Also, this change aligns the Media Widgets and the Customizer site icon and site logo controls with the design pattern used in the new Block Editor for similar controls.

Props ramonopoly, welcher, afercia.
Fixes #43151.

File:

• trunk/src/wp-includes/customize/class-wp-customize-media-control.php (modified) (4 diffs)

trunk/src/wp-includes/customize/class-wp-customize-media-control.php

@@ -133 +133 @@
         ?>
         <#
-        var selectButtonId = _.uniqueId( 'customize-media-control-button-' );
         var descriptionId = _.uniqueId( 'customize-media-control-description-' );
         var describedByAttr = data.description ? ' aria-describedby="' + descriptionId + '" ' : '';
         #>
         <# if ( data.label ) { #>
-            <label class="customize-control-title" for="{{ selectButtonId }}">{{ data.label }}</label>
+            <span class="customize-control-title">{{ data.label }}</span>
         <# } #>
         <div class="customize-control-notifications-container"></div>
@@ -183 +182 @@
                     <# if ( data.canUpload ) { #>
                     <button type="button" class="button remove-button">{{ data.button_labels.remove }}</button>
-                    <button type="button" class="button upload-button control-focus" id="{{ selectButtonId }}" {{{ describedByAttr }}}>{{ data.button_labels.change }}</button>
+                    <button type="button" class="button upload-button control-focus" {{{ describedByAttr }}}>{{ data.button_labels.change }}</button>
                     <# } #>
                 </div>
@@ -189 +188 @@
         <# } else { #>
             <div class="attachment-media-view">
-                <div class="placeholder">
-                        {{ data.button_labels.placeholder }}
-                </div>
+                <# if ( data.canUpload ) { #>
+                    <button type="button" class="upload-button button-add-media" {{{ describedByAttr }}}>{{ data.button_labels.select }}</button>
+                <# } #>
                 <div class="actions">
                     <# if ( data.defaultAttachment ) { #>
                         <button type="button" class="button default-button">{{ data.button_labels['default'] }}</button>
-                    <# } #>
-                    <# if ( data.canUpload ) { #>
-                    <button type="button" class="button upload-button" id="{{ selectButtonId }}" {{{ describedByAttr }}}>{{ data.button_labels.select }}</button>
                     <# } #>
                 </div>
@@ -242 +238 @@
                 return array(
                     'select'       => __( 'Select image' ),
+                    'site_icon'    => __( 'Select site icon' ),
                     'change'       => __( 'Change image' ),
                     'default'      => __( 'Default' ),