Changeset 44973 for trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

Timestamp:

03/21/2019 09:52:07 PM (5 years ago)

Author:

flixos90

Message:

Bootstrap/Load: Introduce a recovery mode for fixing fatal errors.

Using the new fatal handler introduced in [44962], an email is sent to the admin when a fatal error occurs. This email includes a secret link to enter recovery mode. When clicked, the link will be validated and on success a cookie will be placed on the client, enabling recovery mode for that user. This functionality is executed early before plugins and themes are loaded, in order to be unaffected by potential fatal errors these might be causing.

When in recovery mode, broken plugins and themes will be paused for that client, so that they are able to access the admin backend despite of these errors. They are notified about the broken extensions and the errors caused, and can then decide whether they would like to temporarily deactivate the extension or fix the problem and resume the extension.

A link in the admin bar allows the client to exit recovery mode.

Props timothyblynjacobs, afragen, flixos90, nerrad, miss_jwo, schlessera, spacedmonkey, swissspidy.
Fixes #46130, #44458.

File:

• trunk/src/wp-admin/includes/class-wp-plugins-list-table.php (modified) (11 diffs)

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -41 +41 @@
 
         $status = 'all';
-        if ( isset( $_REQUEST['plugin_status'] ) && in_array( $_REQUEST['plugin_status'], array( 'active', 'inactive', 'recently_activated', 'upgrade', 'mustuse', 'dropins', 'search' ) ) ) {
+        if ( isset( $_REQUEST['plugin_status'] ) && in_array( $_REQUEST['plugin_status'], array( 'active', 'inactive', 'recently_activated', 'upgrade', 'mustuse', 'dropins', 'search', 'paused' ) ) ) {
             $status = $_REQUEST['plugin_status'];
         }
@@ -100 +100 @@
             'mustuse'            => array(),
             'dropins'            => array(),
+            'paused'             => array(),
         );
 
@@ -184 +185 @@
             // Extra info if known. array_merge() ensures $plugin_data has precedence if keys collide.
             if ( isset( $plugin_info->response[ $plugin_file ] ) ) {
-                $plugins['all'][ $plugin_file ] = $plugin_data = array_merge( (array) $plugin_info->response[ $plugin_file ], $plugin_data );
+                $plugin_data                    = array_merge( (array) $plugin_info->response[ $plugin_file ], $plugin_data );
+                $plugins['all'][ $plugin_file ] = $plugin_data;
                 // Make sure that $plugins['upgrade'] also receives the extra info since it is used on ?plugin_status=upgrade
                 if ( isset( $plugins['upgrade'][ $plugin_file ] ) ) {
-                    $plugins['upgrade'][ $plugin_file ] = $plugin_data = array_merge( (array) $plugin_info->response[ $plugin_file ], $plugin_data );
+                    $plugins['upgrade'][ $plugin_file ] = $plugin_data;
                 }
             } elseif ( isset( $plugin_info->no_update[ $plugin_file ] ) ) {
-                $plugins['all'][ $plugin_file ] = $plugin_data = array_merge( (array) $plugin_info->no_update[ $plugin_file ], $plugin_data );
+                $plugin_data                    = array_merge( (array) $plugin_info->no_update[ $plugin_file ], $plugin_data );
+                $plugins['all'][ $plugin_file ] = $plugin_data;
                 // Make sure that $plugins['upgrade'] also receives the extra info since it is used on ?plugin_status=upgrade
                 if ( isset( $plugins['upgrade'][ $plugin_file ] ) ) {
-                    $plugins['upgrade'][ $plugin_file ] = $plugin_data = array_merge( (array) $plugin_info->no_update[ $plugin_file ], $plugin_data );
+                    $plugins['upgrade'][ $plugin_file ] = $plugin_data;
                 }
             }
@@ -219 +222 @@
                 // On the network-admin screen, populate the active list with plugins that are network activated
                 $plugins['active'][ $plugin_file ] = $plugin_data;
+
+                if ( ! $screen->in_admin( 'network' ) && is_plugin_paused( $plugin_file ) ) {
+                    $plugins['paused'][ $plugin_file ] = $plugin_data;
+                }
             } else {
                 if ( isset( $recently_activated[ $plugin_file ] ) ) {
@@ -445 +452 @@
                     /* translators: %s: plugin count */
                     $text = _n( 'Drop-ins <span class="count">(%s)</span>', 'Drop-ins <span class="count">(%s)</span>', $count );
+                    break;
+                case 'paused':
+                    /* translators: %s: plugin count */
+                    $text = _n( 'Paused <span class="count">(%s)</span>', 'Paused <span class="count">(%s)</span>', $count );
                     break;
                 case 'upgrade':
@@ -658 +669 @@
                         $actions['deactivate'] = '<a href="' . wp_nonce_url( 'plugins.php?action=deactivate&amp;plugin=' . urlencode( $plugin_file ) . '&amp;plugin_status=' . $context . '&amp;paged=' . $page . '&amp;s=' . $s, 'deactivate-plugin_' . $plugin_file ) . '" aria-label="' . esc_attr( sprintf( _x( 'Deactivate %s', 'plugin' ), $plugin_data['Name'] ) ) . '">' . __( 'Deactivate' ) . '</a>';
                     }
+                    if ( current_user_can( 'resume_plugin', $plugin_file ) && is_plugin_paused( $plugin_file ) ) {
+                        /* translators: %s: plugin name */
+                        $actions['resume'] = '<a class="resume-link" href="' . wp_nonce_url( 'plugins.php?action=resume&amp;plugin=' . urlencode( $plugin_file ) . '&amp;plugin_status=' . $context . '&amp;paged=' . $page . '&amp;s=' . $s, 'resume-plugin_' . $plugin_file ) . '" aria-label="' . esc_attr( sprintf( _x( 'Resume %s', 'plugin' ), $plugin_data['Name'] ) ) . '">' . __( 'Resume' ) . '</a>';
+                    }
                 } else {
                     if ( current_user_can( 'activate_plugin', $plugin_file ) ) {
@@ -764 +779 @@
         if ( ! empty( $totals['upgrade'] ) && ! empty( $plugin_data['update'] ) ) {
             $class .= ' update';
+        }
+
+        $paused = ! $screen->in_admin( 'network' ) && is_plugin_paused( $plugin_file );
+
+        if ( $paused ) {
+            $class .= ' paused';
         }
 
@@ -847 +868 @@
                      * @param string   $status      Status of the plugin. Defaults are 'All', 'Active',
                      *                              'Inactive', 'Recently Activated', 'Upgrade', 'Must-Use',
-                     *                              'Drop-ins', 'Search'.
+                     *                              'Drop-ins', 'Search', 'Paused'.
                      */
                     $plugin_meta = apply_filters( 'plugin_row_meta', $plugin_meta, $plugin_file, $plugin_data, $status );
@@ -853 +874 @@
 
                     echo '</div>';
+
+                    if ( $paused ) {
+                        $notice_text = __( 'This plugin failed to load properly and is paused during recovery mode.' );
+
+                        printf( '<p><span class="dashicons dashicons-warning"></span> <strong>%s</strong></p>', $notice_text );
+
+                        $error = wp_get_plugin_error( $plugin_file );
+
+                        if ( false !== $error ) {
+                            printf( '<div class="error-display"><p>%s</p></div>', wp_get_extension_error_description( $error ) );
+                        }
+                    }
 
                     echo '</td>';
@@ -887 +920 @@
          * @param string $status      Status of the plugin. Defaults are 'All', 'Active',
          *                            'Inactive', 'Recently Activated', 'Upgrade', 'Must-Use',
-         *                            'Drop-ins', 'Search'.
+         *                            'Drop-ins', 'Search', 'Paused'.
          */
         do_action( 'after_plugin_row', $plugin_file, $plugin_data, $status );
@@ -903 +936 @@
          * @param string $status      Status of the plugin. Defaults are 'All', 'Active',
          *                            'Inactive', 'Recently Activated', 'Upgrade', 'Must-Use',
-         *                            'Drop-ins', 'Search'.
+         *                            'Drop-ins', 'Search', 'Paused'.
          */
         do_action( "after_plugin_row_{$plugin_file}", $plugin_file, $plugin_data, $status );