Changeset 45028 for trunk/src/wp-includes/general-template.php

Timestamp:

03/27/2019 12:15:15 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Themes: Remove itemprop="url" from get_custom_logo() output.

Making incorrect assumptions about microdata used in a theme results in invalid markup.

The attribute can still be added using the get_custom_logo or wp_get_attachment_image_attributes filter, but it should not be added by default.

Props henry.wright, tfrommen, afercia, markcallen, zodiac1978.
Fixes #37305.

File:

• trunk/src/wp-includes/general-template.php (modified) (2 diffs)

trunk/src/wp-includes/general-template.php

@@ -949 +949 @@
     if ( $custom_logo_id ) {
         $custom_logo_attr = array(
-            'class'    => 'custom-logo',
-            'itemprop' => 'logo',
+            'class' => 'custom-logo',
         );
 
@@ -967 +966 @@
          */
         $html = sprintf(
-            '<a href="%1$s" class="custom-logo-link" rel="home" itemprop="url">%2$s</a>',
+            '<a href="%1$s" class="custom-logo-link" rel="home">%2$s</a>',
             esc_url( home_url( '/' ) ),
             wp_get_attachment_image( $custom_logo_id, 'full', false, $custom_logo_attr )