Changeset 45260

Timestamp:

04/23/2019 09:36:02 PM (5 years ago)

Author:

azaozz

Message:

Site Health: Fix count of inactive themes and the recommendation to remove them when the default theme is active or is a parent of the active child theme.

Props sudhiryadav, ianbelanger, mukesh27, azaozz.
Fixes #46900.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -465 +465 @@
         if ( $active_theme->parent() ) {
             $allowed_theme_count++;
-        }
-
-        // If there's a default theme installed, we count that as allowed as well.
-        if ( $has_default_theme ) {
+
+            if ( $active_theme->get_template() === WP_DEFAULT_THEME ) {
+                $using_default_theme = true;
+            }
+        }
+
+        // If there's a default theme installed and not in use, we count that as allowed as well.
+        if ( $has_default_theme && ! $using_default_theme ) {
             $allowed_theme_count++;
         }