Changeset 45262 for trunk/src/wp-admin/includes/class-core-upgrader.php

Timestamp:

04/24/2019 07:43:29 AM (4 years ago)

Author:

tellyworth

Message:

Upgrade/install: fix verification bugs and scale back signature checks.

This fixes several bugs in the signature verification code:
Disables signature checks on certain incompatible PHP versions that cause math errors when opcache is enabled;
Prevents a spurious URL and subsequent error when downloading a zip file with query arguments;
Prevents errors triggered by third-party upgrade scripts as per #46615;
Disables signature tests for Plugins, Themes, and Translations, leaving only core updates.

At the 5.2 release the API servers will only provide signatures for core update packages, which is why messages are suppressed for plugins and other package types. Signatures for those other items will become available later.

Props dd32.
See #39309, #46615

File:

• trunk/src/wp-admin/includes/class-core-upgrader.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-core-upgrader.php

@@ -122 +122 @@
         }
 
-        $download = $this->download_package( $current->packages->$to_download );
+        $download = $this->download_package( $current->packages->$to_download, true );
 
         // Allow for signature soft-fail.