Changeset 45611 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

07/09/2019 05:44:42 AM (7 years ago)

Author:

pento

Message:

Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged.

Noteable changes:

• The magic_quotes_runtime and magic_quotes_sybase settings were removed in PHP 5.4, so no longer need to be set.
• Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
• Quite a few functions would cause errors if safe_mode was set. This setting was removed in PHP 5.4.
• Only a handful of header() calls needed corresponding headers_sent() checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (7 diffs)

trunk/src/wp-admin/includes/upgrade.php

@@ -609 +609 @@
                 );
 
-                @wp_mail( $email, __( 'New WordPress Site' ), $message );
+                wp_mail( $email, __( 'New WordPress Site' ), $message );
         }
 endif;
@@ -2970 +2970 @@
                         $index = implode( '', file( "$oldpath/$oldfile" ) );
                         if ( strpos( $index, 'WP_USE_THEMES' ) !== false ) {
-                                if ( ! @copy( WP_CONTENT_DIR . '/themes/' . WP_DEFAULT_THEME . '/index.php', "$site_dir/$newfile" ) ) {
+                                if ( ! copy( WP_CONTENT_DIR . '/themes/' . WP_DEFAULT_THEME . '/index.php', "$site_dir/$newfile" ) ) {
                                         return false;
                                 }
@@ -2979 +2979 @@
                 }
 
-                if ( ! @copy( "$oldpath/$oldfile", "$site_dir/$newfile" ) ) {
+                if ( ! copy( "$oldpath/$oldfile", "$site_dir/$newfile" ) ) {
                         return false;
                 }
@@ -3040 +3040 @@
         //$files = array('index.php', 'comments.php', 'comments-popup.php', 'footer.php', 'header.php', 'sidebar.php', 'style.css');
 
-        $theme_dir = @ opendir( $default_dir );
+        $theme_dir = @opendir( $default_dir );
         if ( $theme_dir ) {
                 while ( ( $theme_file = readdir( $theme_dir ) ) !== false ) {
@@ -3046 +3046 @@
                                 continue;
                         }
-                        if ( ! @copy( "$default_dir/$theme_file", "$site_dir/$theme_file" ) ) {
+                        if ( ! copy( "$default_dir/$theme_file", "$site_dir/$theme_file" ) ) {
                                 return;
                         }
                         chmod( "$site_dir/$theme_file", 0777 );
                 }
-        }
-        @closedir( $theme_dir );
+
+                closedir( $theme_dir );
+        }
 
         // Rewrite the theme header.
@@ -3082 +3083 @@
         }
 
-        $images_dir = @ opendir( "$default_dir/images" );
+        $images_dir = @opendir( "$default_dir/images" );
         if ( $images_dir ) {
                 while ( ( $image = readdir( $images_dir ) ) !== false ) {
@@ -3088 +3089 @@
                                 continue;
                         }
-                        if ( ! @copy( "$default_dir/images/$image", "$site_dir/images/$image" ) ) {
+                        if ( ! copy( "$default_dir/images/$image", "$site_dir/images/$image" ) ) {
                                 return;
                         }
                         chmod( "$site_dir/images/$image", 0777 );
                 }
-        }
-        @closedir( $images_dir );
+
+                closedir( $images_dir );
+        }
 }