WordPress.org

Make WordPress Core


Ignore:
Timestamp:
08/15/2019 09:08:05 PM (2 months ago)
Author:
kadamwhite
Message:

REST API: Cache results of get_item_schema on controller instances for performance.

Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.

Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php

    r45632 r45811  
    11791179     */
    11801180    public function get_item_schema() {
     1181        if ( $this->schema ) {
     1182            return $this->add_additional_fields_schema( $this->schema );
     1183        }
     1184
    11811185        $schema = array(
    11821186            '$schema'    => 'http://json-schema.org/draft-04/schema#',
     
    13351339        $schema['properties']['meta'] = $this->meta->get_field_schema();
    13361340
    1337         return $this->add_additional_fields_schema( $schema );
     1341        $this->schema = $schema;
     1342        return $this->add_additional_fields_schema( $this->schema );
    13381343    }
    13391344
Note: See TracChangeset for help on using the changeset viewer.