Changeset 45851 for trunk/src/wp-includes/post.php

Timestamp:

08/19/2019 03:49:32 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: In wp_insert_post(), when checking the post date to set future or publish status, use string comparison to work around far future dates (year 2038+) on 32-bit systems.

Props Rarst, nofearinc.
Fixes #25347.

File:

• trunk/src/wp-includes/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -3664 +3664 @@
 
     if ( 'attachment' !== $post_type ) {
-        if ( 'publish' == $post_status ) {
-            $now = gmdate( 'Y-m-d H:i:59' );
-            if ( mysql2date( 'U', $post_date_gmt, false ) > mysql2date( 'U', $now, false ) ) {
+        if ( 'publish' === $post_status ) {
+            // String comparison to work around far future dates (year 2038+) on 32-bit systems.
+            if ( $post_date_gmt > gmdate( 'Y-m-d H:i:59' ) ) {
                 $post_status = 'future';
             }
-        } elseif ( 'future' == $post_status ) {
-            $now = gmdate( 'Y-m-d H:i:59' );
-            if ( mysql2date( 'U', $post_date_gmt, false ) <= mysql2date( 'U', $now, false ) ) {
+        } elseif ( 'future' === $post_status ) {
+            if ( $post_date_gmt <= gmdate( 'Y-m-d H:i:59' ) ) {
                 $post_status = 'publish';
             }