Make WordPress Core


Ignore:
Timestamp:
09/04/2019 05:14:13 PM (6 years ago)
Author:
SergeyBiryukov
Message:

Improve URL validation in wp_validate_redirect().

Merges [45971] to the 4.0 branch.
Props vortfu, whyisjake, peterwilsoncc.

Location:
branches/4.0
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/4.0

  • branches/4.0/src/wp-includes/pluggable.php

    r40191 r45985  
    12631263        return $default;
    12641264
     1265    if ( ! isset( $lp['host'] ) && ! empty( $lp['path'] ) && '/' !== $lp['path'][0] ) {
     1266        $path = '';
     1267        if ( ! empty( $_SERVER['REQUEST_URI'] ) ) {
     1268            $path = dirname( parse_url( 'http://placeholder' . $_SERVER['REQUEST_URI'], PHP_URL_PATH ) . '?' );
     1269        }
     1270        $location = '/' . ltrim( $path . '/', '/' ) . $location;
     1271    }
     1272
    12651273    // Reject if certain components are set but host is not. This catches urls like https:host.com for which parse_url does not set the host field.
    12661274    if ( ! isset( $lp['host'] ) && ( isset( $lp['scheme'] ) || isset( $lp['user'] ) || isset( $lp['pass'] ) || isset( $lp['port'] ) ) ) {
Note: See TracChangeset for help on using the changeset viewer.