Changeset 46105 for trunk/src/wp-admin/includes/class-pclzip.php

Timestamp:

09/13/2019 10:19:34 PM (5 years ago)

Author:

jorbin

Message:

GENERAL: Remove magic quote functions

The path to magic quote sanity took a fun and exciting turn: PHP core removed it and WordPress updated the minimum version.

For the formally external pclzip, the code is commented out to make investigating easier and in case we ever need to merge upstream (if that still exists) changes.

Props ayeshrajans, jrf, jorbin.
See #47783.
Fixes #18322.

File:

• trunk/src/wp-admin/includes/class-pclzip.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-pclzip.php

@@ -5327 +5327 @@
     $v_result=1;
 
+    // EDIT for WordPress 5.3.0
+    // magic_quote functions are deprecated in PHP 7.4, now assuming it's always off.
+    /*
+
     // ----- Look if function exists
     if (   (!function_exists("get_magic_quotes_runtime"))
@@ -5345 +5349 @@
       @set_magic_quotes_runtime(0);
     }
+    */
 
     // ----- Return
@@ -5360 +5365 @@
   {
     $v_result=1;
+
+    // EDIT for WordPress 5.3.0
+    // magic_quote functions are deprecated in PHP 7.4, now assuming it's always off.
+    /*
 
     // ----- Look if function exists
@@ -5377 +5386 @@
     }
 
+    */
     // ----- Return
     return $v_result;