Changeset 46186 for trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php

Timestamp:

09/19/2019 02:35:47 PM (6 years ago)

Author:

kadamwhite

Message:

REST API: Issue warning if array meta is registered without item schema.

The purpose of meta registration is to assert that the meta key will contain a predictable value conforming to a schema, so the schema is therefore considered to be required.

Props TimothyBlynJacobs, grapplerulrich.
Fixes #43392.

File:

• trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php

@@ -2206 +2206 @@
 
     /**
+     * @ticket 43392
+     */
+    public function test_register_meta_issues_doing_it_wrong_when_show_in_rest_is_true() {
+        $this->setExpectedIncorrectUsage( 'register_meta' );
+
+        $registered = register_meta(
+            'post',
+            'invalid_array',
+            array(
+                'type'         => 'array',
+                'show_in_rest' => true,
+            )
+        );
+
+        self::assertFalse( $registered );
+    }
+
+    /**
+     * @ticket 43392
+     */
+    public function test_register_meta_issues_doing_it_wrong_when_show_in_rest_omits_schema() {
+        $this->setExpectedIncorrectUsage( 'register_meta' );
+
+        $registered = register_meta(
+            'post',
+            'invalid_array',
+            array(
+                'type'         => 'array',
+                'show_in_rest' => array(
+                    'prepare_callback' => 'rest_sanitize_value_from_schema',
+                ),
+            )
+        );
+
+        self::assertFalse( $registered );
+    }
+
+    /**
+     * @ticket 43392
+     */
+    public function test_register_meta_issues_doing_it_wrong_when_show_in_rest_omits_schema_items() {
+        $this->setExpectedIncorrectUsage( 'register_meta' );
+
+        $registered = register_meta(
+            'post',
+            'invalid_array',
+            array(
+                'type'         => 'array',
+                'show_in_rest' => array(
+                    'schema' => array(
+                        'default' => array( 'Hi!' ),
+                    ),
+                ),
+            )
+        );
+
+        self::assertFalse( $registered );
+    }
+
+    /**
      * Internal function used to disable an insert query which
      * will trigger a wpdb error for testing purposes.