Changeset 47198 for trunk/src/wp-admin/tools.php

Timestamp:

02/06/2020 06:31:22 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/tools.php (modified) (4 diffs)

trunk/src/wp-admin/tools.php

@@ -11 +11 @@
     // continues to work after creating the new files for exporting and erasing of personal data.
     if ( $_GET['page'] === 'export_personal_data' ) {
-        require_once( ABSPATH . 'wp-admin/export-personal-data.php' );
+        require_once ABSPATH . 'wp-admin/export-personal-data.php';
         return;
     } elseif ( $_GET['page'] === 'remove_personal_data' ) {
-        require_once( ABSPATH . 'wp-admin/erase-personal-data.php' );
+        require_once ABSPATH . 'wp-admin/erase-personal-data.php';
         return;
     }
@@ -20 +20 @@
 
 /** WordPress Administration Bootstrap */
-require_once( dirname( __FILE__ ) . '/admin.php' );
+require_once __DIR__ . '/admin.php';
 
 // The privacy policy guide used to be outputted from here. Since WP 5.3 it is in wp-admin/privacy-policy-guide.php.
@@ -54 +54 @@
 );
 
-require_once( ABSPATH . 'wp-admin/admin-header.php' );
+require_once ABSPATH . 'wp-admin/admin-header.php';
 
 ?>
@@ -93 +93 @@
 <?php
 
-include( ABSPATH . 'wp-admin/admin-footer.php' );
+require_once ABSPATH . 'wp-admin/admin-footer.php';