Changeset 47198 for trunk/src/wp-includes/update.php

Timestamp:

02/06/2020 06:31:22 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-includes/update.php (modified) (5 diffs)

trunk/src/wp-includes/update.php

@@ -29 +29 @@
     global $wpdb, $wp_local_package;
     // Include an unmodified $wp_version.
-    include( ABSPATH . WPINC . '/version.php' );
+    require ABSPATH . WPINC . '/version.php';
     $php_version = phpversion();
 
@@ -262 +262 @@
 
     // Include an unmodified $wp_version.
-    include( ABSPATH . WPINC . '/version.php' );
+    require ABSPATH . WPINC . '/version.php';
 
     // If running blog-side, bail unless we've not checked in the last 12 hours.
     if ( ! function_exists( 'get_plugins' ) ) {
-        require_once( ABSPATH . 'wp-admin/includes/plugin.php' );
+        require_once ABSPATH . 'wp-admin/includes/plugin.php';
     }
 
@@ -442 +442 @@
 
     // Include an unmodified $wp_version.
-    include( ABSPATH . WPINC . '/version.php' );
+    require ABSPATH . WPINC . '/version.php';
 
     $installed_themes = wp_get_themes();
@@ -604 +604 @@
  */
 function wp_maybe_auto_update() {
-    include_once( ABSPATH . 'wp-admin/includes/admin.php' );
-    include_once( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' );
+    include_once ABSPATH . 'wp-admin/includes/admin.php';
+    require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
 
     $upgrader = new WP_Automatic_Updater;
@@ -730 +730 @@
 function _maybe_update_core() {
     // Include an unmodified $wp_version.
-    include( ABSPATH . WPINC . '/version.php' );
+    require ABSPATH . WPINC . '/version.php';
 
     $current = get_site_transient( 'update_core' );