Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/update.php

    r47122 r47198  
    2929    global $wpdb, $wp_local_package;
    3030    // Include an unmodified $wp_version.
    31     include( ABSPATH . WPINC . '/version.php' );
     31    require ABSPATH . WPINC . '/version.php';
    3232    $php_version = phpversion();
    3333
     
    262262
    263263    // Include an unmodified $wp_version.
    264     include( ABSPATH . WPINC . '/version.php' );
     264    require ABSPATH . WPINC . '/version.php';
    265265
    266266    // If running blog-side, bail unless we've not checked in the last 12 hours.
    267267    if ( ! function_exists( 'get_plugins' ) ) {
    268         require_once( ABSPATH . 'wp-admin/includes/plugin.php' );
     268        require_once ABSPATH . 'wp-admin/includes/plugin.php';
    269269    }
    270270
     
    442442
    443443    // Include an unmodified $wp_version.
    444     include( ABSPATH . WPINC . '/version.php' );
     444    require ABSPATH . WPINC . '/version.php';
    445445
    446446    $installed_themes = wp_get_themes();
     
    604604 */
    605605function wp_maybe_auto_update() {
    606     include_once( ABSPATH . 'wp-admin/includes/admin.php' );
    607     include_once( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' );
     606    include_once ABSPATH . 'wp-admin/includes/admin.php';
     607    require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
    608608
    609609    $upgrader = new WP_Automatic_Updater;
     
    730730function _maybe_update_core() {
    731731    // Include an unmodified $wp_version.
    732     include( ABSPATH . WPINC . '/version.php' );
     732    require ABSPATH . WPINC . '/version.php';
    733733
    734734    $current = get_site_transient( 'update_core' );
Note: See TracChangeset for help on using the changeset viewer.