Changeset 47219 for trunk/src/wp-admin/includes/media.php

Timestamp:

02/09/2020 04:52:28 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions where appropriate.

See #49222.

File:

• trunk/src/wp-admin/includes/media.php (modified) (20 diffs)

trunk/src/wp-admin/includes/media.php

@@ -636 +636 @@
     $img = '<span class="wp-media-buttons-icon"></span> ';
 
-    $id_attribute = $instance === 1 ? ' id="insert-media-button"' : '';
+    $id_attribute = 1 === $instance ? ' id="insert-media-button"' : '';
 
     printf(
@@ -768 +768 @@
                 $image_alt = wp_unslash( $attachment['image_alt'] );
 
-                if ( $image_alt != get_post_meta( $attachment_id, '_wp_attachment_image_alt', true ) ) {
+                if ( get_post_meta( $attachment_id, '_wp_attachment_image_alt', true ) !== $image_alt ) {
                     $image_alt = wp_strip_all_tags( $image_alt, true );
 
@@ -948 +948 @@
     }
 
-    if ( isset( $_GET['tab'] ) && $_GET['tab'] == 'type_url' ) {
+    if ( isset( $_GET['tab'] ) && 'type_url' === $_GET['tab'] ) {
         $type = 'image';
 
@@ -1004 +1004 @@
             return $id;
             // If attachment id was requested, return it early.
-        } elseif ( $return === 'id' ) {
+        } elseif ( 'id' === $return ) {
             return $id;
         }
@@ -1013 +1013 @@
     // Finally, check to make sure the file has been saved, then return the HTML.
     if ( ! empty( $src ) ) {
-        if ( $return === 'src' ) {
+        if ( 'src' === $return ) {
             return $src;
         }
@@ -1212 +1212 @@
     $url = '';
 
-    if ( $url_type == 'file' ) {
+    if ( 'file' === $url_type ) {
         $url = $file;
-    } elseif ( $url_type == 'post' ) {
+    } elseif ( 'post' === $url_type ) {
         $url = $link;
     }
@@ -1325 +1325 @@
         $size  = ! empty( $attachment['image-size'] ) ? $attachment['image-size'] : 'medium';
         $alt   = ! empty( $attachment['image_alt'] ) ? $attachment['image_alt'] : '';
-        $rel   = ( strpos( $url, 'attachment_id' ) || $url === get_attachment_link( $attachment_id ) );
+        $rel   = ( strpos( $url, 'attachment_id' ) || get_attachment_link( $attachment_id ) === $url );
 
         return get_image_send_to_editor( $attachment_id, $attachment['post_excerpt'], $attachment['post_title'], $align, $url, $rel, $size, $alt );
@@ -1492 +1492 @@
         $post = get_post( $post_id );
 
-        if ( $post && $post->post_type == 'attachment' ) {
+        if ( $post && 'attachment' === $post->post_type ) {
             $attachments = array( $post->ID => $post );
         } else {
@@ -1514 +1514 @@
     $output = '';
     foreach ( (array) $attachments as $id => $attachment ) {
-        if ( $attachment->post_status == 'trash' ) {
+        if ( 'trash' === $attachment->post_status ) {
             continue;
         }
@@ -1736 +1736 @@
 
     foreach ( $form_fields as $id => $field ) {
-        if ( $id[0] == '_' ) {
+        if ( '_' === $id[0] ) {
             continue;
         }
@@ -1748 +1748 @@
         $name  = "attachments[$attachment_id][$id]";
 
-        if ( $field['input'] == 'hidden' ) {
+        if ( 'hidden' === $field['input'] ) {
             $hidden_fields[ $name ] = $field['value'];
             continue;
@@ -1762 +1762 @@
         if ( ! empty( $field[ $field['input'] ] ) ) {
             $item .= $field[ $field['input'] ];
-        } elseif ( $field['input'] == 'textarea' ) {
+        } elseif ( 'textarea' === $field['input'] ) {
             if ( 'post_content' == $id && user_can_richedit() ) {
                 // Sanitize_post() skips the post_content when user_can_richedit.
@@ -1920 +1920 @@
 
     foreach ( $form_fields as $id => $field ) {
-        if ( $id[0] == '_' ) {
+        if ( '_' === $id[0] ) {
             continue;
         }
@@ -1938 +1938 @@
         }
 
-        if ( $field['input'] == 'hidden' ) {
+        if ( 'hidden' === $field['input'] ) {
             $hidden_fields[ $name ] = $field['value'];
             continue;
@@ -1955 +1955 @@
         if ( ! empty( $field[ $field['input'] ] ) ) {
             $item .= $field[ $field['input'] ];
-        } elseif ( $field['input'] == 'textarea' ) {
+        } elseif ( 'textarea' === $field['input'] ) {
             if ( 'post_content' == $id && user_can_richedit() ) {
                 // sanitize_post() skips the post_content when user_can_richedit.
@@ -2717 +2717 @@
             list($post_mime_types, $avail_post_mime_types) = wp_edit_attachments_query();
         }
-        if ( empty( $_GET['post_mime_type'] ) || $_GET['post_mime_type'] == 'all' ) {
+        if ( empty( $_GET['post_mime_type'] ) || 'all' === $_GET['post_mime_type'] ) {
             $class = ' class="current"';
         } else {
@@ -2801 +2801 @@
 
             foreach ( $arc_result as $arc_row ) {
-                if ( $arc_row->yyear == 0 ) {
+                if ( 0 == $arc_row->yyear ) {
                     continue;
                 }
@@ -2927 +2927 @@
             <th scope="row" class="label"><p><label for="align">' . __( 'Alignment' ) . '</label></p></th>
             <td class="field">
-                <input name="align" id="align-none" value="none" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ( $default_align == 'none' ? ' checked="checked"' : '' ) . ' />
+                <input name="align" id="align-none" value="none" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ( 'none' === $default_align ? ' checked="checked"' : '' ) . ' />
                 <label for="align-none" class="align image-align-none-label">' . __( 'None' ) . '</label>
-                <input name="align" id="align-left" value="left" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ( $default_align == 'left' ? ' checked="checked"' : '' ) . ' />
+                <input name="align" id="align-left" value="left" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ( 'left' === $default_align ? ' checked="checked"' : '' ) . ' />
                 <label for="align-left" class="align image-align-left-label">' . __( 'Left' ) . '</label>
-                <input name="align" id="align-center" value="center" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ( $default_align == 'center' ? ' checked="checked"' : '' ) . ' />
+                <input name="align" id="align-center" value="center" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ( 'center' === $default_align ? ' checked="checked"' : '' ) . ' />
                 <label for="align-center" class="align image-align-center-label">' . __( 'Center' ) . '</label>
-                <input name="align" id="align-right" value="right" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ( $default_align == 'right' ? ' checked="checked"' : '' ) . ' />
+                <input name="align" id="align-right" value="right" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ( 'right' === $default_align ? ' checked="checked"' : '' ) . ' />
                 <label for="align-right" class="align image-align-right-label">' . __( 'Right' ) . '</label>
             </td>
@@ -3273 +3273 @@
             echo esc_html( strtoupper( $matches[1] ) );
             list( $mime_type ) = explode( '/', $post->post_mime_type );
-            if ( $mime_type !== 'image' && ! empty( $meta['mime_type'] ) ) {
-                if ( $meta['mime_type'] !== "$mime_type/" . strtolower( $matches[1] ) ) {
+            if ( 'image' !== $mime_type && ! empty( $meta['mime_type'] ) ) {
+                if ( "$mime_type/" . strtolower( $matches[1] ) !== $meta['mime_type'] ) {
                     echo ' (' . $meta['mime_type'] . ')';
                 }
@@ -3536 +3536 @@
         $created_timestamp = wp_get_media_creation_timestamp( $data );
 
-        if ( $created_timestamp !== false ) {
+        if ( false !== $created_timestamp ) {
             $metadata['created_timestamp'] = $created_timestamp;
         }