Changeset 47550 for trunk/src/wp-admin/includes/class-wp-automatic-updater.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/class-wp-automatic-updater.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-automatic-updater.php

@@ -578 +578 @@
         $send               = true;
         $transient_failures = array( 'incompatible_archive', 'download_failed', 'insane_distro', 'locked' );
-        if ( in_array( $error_code, $transient_failures ) && ! get_site_option( 'auto_core_update_failed' ) ) {
+        if ( in_array( $error_code, $transient_failures, true ) && ! get_site_option( 'auto_core_update_failed' ) ) {
             wp_schedule_single_event( time() + HOUR_IN_SECONDS, 'wp_maybe_auto_update' );
             $send = false;
@@ -597 +597 @@
                 'error_data' => $result->get_error_data(),
                 'timestamp'  => time(),
-                'retry'      => in_array( $error_code, $transient_failures ),
+                'retry'      => in_array( $error_code, $transient_failures, true ),
             )
         );