Changeset 47808 for trunk/src/wp-admin/includes/class-walker-nav-menu-edit.php

Timestamp:

05/16/2020 06:40:52 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/class-walker-nav-menu-edit.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-walker-nav-menu-edit.php

@@ -73 +73 @@
         $original_title = false;
 
-        if ( 'taxonomy' == $item->type ) {
+        if ( 'taxonomy' === $item->type ) {
             $original_object = get_term( (int) $item->object_id, $item->object );
             if ( $original_object && ! is_wp_error( $original_title ) ) {
                 $original_title = $original_object->name;
             }
-        } elseif ( 'post_type' == $item->type ) {
+        } elseif ( 'post_type' === $item->type ) {
             $original_object = get_post( $item->object_id );
             if ( $original_object ) {
                 $original_title = get_the_title( $original_object->ID );
             }
-        } elseif ( 'post_type_archive' == $item->type ) {
+        } elseif ( 'post_type_archive' === $item->type ) {
             $original_object = get_post_type_object( $item->object );
             if ( $original_object ) {
@@ -102 +102 @@
             /* translators: %s: Title of an invalid menu item. */
             $title = sprintf( __( '%s (Invalid)' ), $item->title );
-        } elseif ( isset( $item->post_status ) && 'draft' == $item->post_status ) {
+        } elseif ( isset( $item->post_status ) && 'draft' === $item->post_status ) {
             $classes[] = 'pending';
             /* translators: %s: Title of a menu item in draft status. */
@@ -108 +108 @@
         }
 
-        $title = ( ! isset( $item->label ) || '' == $item->label ) ? $title : $item->label;
+        $title = ( ! isset( $item->label ) || '' === $item->label ) ? $title : $item->label;
 
         $submenu_text = '';
@@ -182 +182 @@
 
             <div class="menu-item-settings wp-clearfix" id="menu-item-settings-<?php echo $item_id; ?>">
-                <?php if ( 'custom' == $item->type ) : ?>
+                <?php if ( 'custom' === $item->type ) : ?>
                     <p class="field-url description description-wide">
                         <label for="edit-menu-item-url-<?php echo $item_id; ?>">