Changeset 47850 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

Timestamp:

05/23/2020 03:22:53 PM (5 years ago)

Author:

ocean90

Message:

Role/Capability: Use meta caps edit_post, read_post, and delete_post directly.

Rather than consulting the post type object, let map_meta_cap() handle that for us.

Props peterwilsoncc, ocean90.
Fixes #50128.
See #23226.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

@@ -110 +110 @@
 
         // Attaching media to a post requires ability to edit said post.
-        if ( ! empty( $request['post'] ) ) {
-            $parent           = get_post( (int) $request['post'] );
-            $post_parent_type = get_post_type_object( $parent->post_type );
-
-            if ( ! current_user_can( $post_parent_type->cap->edit_post, $request['post'] ) ) {
-                return new WP_Error(
-                    'rest_cannot_edit',
-                    __( 'Sorry, you are not allowed to upload media to this post.' ),
-                    array( 'status' => rest_authorization_required_code() )
-                );
-            }
+        if ( ! empty( $request['post'] ) && ! current_user_can( 'edit_post', (int) $request['post'] ) ) {
+            return new WP_Error(
+                'rest_cannot_edit',
+                __( 'Sorry, you are not allowed to upload media to this post.' ),
+                array( 'status' => rest_authorization_required_code() )
+            );
         }