Changeset 48414 for trunk/src/wp-includes/sitemaps/class-wp-sitemaps-stylesheet.php

Timestamp:

07/10/2020 12:48:54 AM (6 years ago)

Author:

whyisjake

Message:

Sitemaps: Add better support for RTL sites.

While the URLs are intended to be machine readable, they should always be LTR, while other data would be RTL in the sitemap.

Fixes #50449.

Props joyously, SergeyBiryukov, pbiron. apedog, ramiy.

File:

• trunk/src/wp-includes/sitemaps/class-wp-sitemaps-stylesheet.php (modified) (1 diff)

trunk/src/wp-includes/sitemaps/class-wp-sitemaps-stylesheet.php

@@ -249 +249 @@
          */
         public function get_stylesheet_css() {
-                $css = '
-                        body {
-                                font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
-                                color: #444;
-                        }
-
-                        #sitemap__table {
-                                border: solid 1px #ccc;
-                                border-collapse: collapse;
-                        }
-
-                        #sitemap__table tr th {
-                                text-align: left;
-                        }
-
-                        #sitemap__table tr td,
-                        #sitemap__table tr th {
-                                padding: 10px;
-                        }
-
-                        #sitemap__table tr:nth-child(odd) td {
-                                background-color: #eee;
-                        }
-
-                        a:hover {
-                                text-decoration: none;
-                        }';
+                $text_align = is_rtl() ? 'right' : 'left';
+
+                $css = <<<EOF
+                
+                                        body {
+                                                font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
+                                                color: #444;
+                                        }
+                                        
+                                        #sitemap__table {
+                                                border: solid 1px #ccc;
+                                                border-collapse: collapse;
+                                        }
+                                        
+                                        #sitemap__table tr td.loc {
+                                                /*
+                                                 * URLs should always be LTR.
+                                                 * see https://core.trac.wordpress.org/ticket/16834 and
+                                                 * https://core.trac.wordpress.org/ticket/49949
+                                                 */
+                                                direction: ltr;
+                                        }
+                                        
+                                        #sitemap__table tr th {
+                                                text-align: {$text_align};
+                                        }
+                                        
+                                        #sitemap__table tr td,
+                                        #sitemap__table tr th {
+                                                padding: 10px;
+                                        }
+                                        
+                                        #sitemap__table tr:nth-child(odd) td {
+                                                background-color: #eee;
+                                        }
+                                        
+                                        a:hover {
+                                                text-decoration: none;
+                                        }
+EOF;
 
                 /**