Changeset 48422 for trunk/src/wp-admin/includes/meta-boxes.php

Timestamp:

07/10/2020 03:12:00 PM (5 years ago)

Author:

adamsilverstein

Message:

Revisions: optimize performance when post has large number of revisions.

Improve speed and reduce the memory footprint when loading posts with many revisions.

• Use a direct query in wp_get_post_autosave to avoid loading all revisions.
• Query for IDs vs full objects in register_and_do_post_meta_boxes.

Props pdfernhout, johnnyb, miqrogroove, ocean90, senatorman, DBrumbaugh10Up, martijn-van-der-kooij, pavelevap, mackensen, mikeyarce, whyisjake.
Fixes #34560.

File:

• trunk/src/wp-admin/includes/meta-boxes.php (modified) (2 diffs)

trunk/src/wp-admin/includes/meta-boxes.php

@@ -1438 +1438 @@
     $publish_callback_args = array( '__back_compat_meta_box' => true );
     if ( post_type_supports( $post_type, 'revisions' ) && 'auto-draft' !== $post->post_status ) {
-        $revisions = wp_get_post_revisions( $post->ID );
+        $revisions = wp_get_post_revisions( $post->ID, array( 'fields' => 'ids' ) );
 
         // We should aim to show the revisions meta box only when there are revisions.
@@ -1445 +1445 @@
             $publish_callback_args = array(
                 'revisions_count'        => count( $revisions ),
-                'revision_id'            => key( $revisions ),
+                'revision_id'            => array_shift( $revisions ),
                 '__back_compat_meta_box' => true,
             );