Changeset 48621

Timestamp:

07/26/2020 02:06:03 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Pings/Trackbacks: Avoid a PHP notice in do_enclose() when encountering a URL without a path in post content.

Props jbouganim, mukesh27, Otto42, SergeyBiryukov.
Fixes #49872.

Location:

trunk

Files:

• src/wp-includes/functions.php (modified) (1 diff)
• tests/phpunit/tests/functions/doEnclose.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -908 +908 @@
                 // Check to see if we can figure out the mime type from the extension.
                 $url_parts = parse_url( $url );
-                if ( false !== $url_parts ) {
+                if ( false !== $url_parts && ! empty( $url_parts['path'] ) ) {
                     $extension = pathinfo( $url_parts['path'], PATHINFO_EXTENSION );
                     if ( ! empty( $extension ) ) {

trunk/tests/phpunit/tests/functions/doEnclose.php

@@ -136 +136 @@
                                 "https://example.com/wp-content/uploads/2018/06/movie.mp4\n123\nvideo/mp4\n",
             ),
+            'no-path'               => array(
+                'content'  => 'https://example.com?test=1',
+                'expected' => '',
+            ),
         );
     }