Changeset 48666

Timestamp:

07/28/2020 04:05:39 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file.

Props mariovalney, desrosj.
See #50593.

Location:

trunk/src/wp-admin/includes

Files:

• class-plugin-upgrader.php (modified) (1 diff)
• class-theme-installer-skin.php (modified) (1 diff)
• class-theme-upgrader.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-plugin-upgrader.php

@@ -442 +442 @@
                 }
 
+                $requires_php = isset( $info['RequiresPHP'] ) ? $info['RequiresPHP'] : null;
+                $requires_wp  = isset( $info['RequiresWP'] ) ? $info['RequiresWP'] : null;
+
+                if ( ! is_php_version_compatible( $requires_php ) ) {
+                        $error = sprintf(
+                                /* translators: 1: Current PHP version, 2: Version required by the uploaded plugin. */
+                                __( 'The PHP version on your server is %1$s, however the uploaded plugin requires %2$s.' ),
+                                phpversion(),
+                                $requires_php
+                        );
+
+                        return new WP_Error( 'incompatible_php_required_version', $this->strings['incompatible_archive'], $error );
+                }
+
+                if ( ! is_wp_version_compatible( $requires_wp ) ) {
+                        $error = sprintf(
+                                /* translators: 1: Current WordPress version, 2: Version required by the uploaded plugin. */
+                                __( 'Your WordPress version is %1$s, however the uploaded plugin requires %2$s.' ),
+                                $GLOBALS['wp_version'],
+                                $requires_wp
+                        );
+
+                        return new WP_Error( 'incompatible_wp_required_version', $this->strings['incompatible_archive'], $error );
+                }
+
                 return $source;
         }

trunk/src/wp-admin/includes/class-theme-installer-skin.php

@@ -222 +222 @@
                 echo '<h2 class="update-from-upload-heading">' . esc_html( __( 'This theme is already installed.' ) ) . '</h2>';
 
-                // Check errors for current theme
+                // Check errors for current theme.
                 if ( is_wp_error( $current_theme_data->errors() ) ) {
                         $this->feedback( 'current_theme_has_errors', $current_theme_data->errors()->get_error_message() );

trunk/src/wp-admin/includes/class-theme-upgrader.php

@@ -589 +589 @@
                 }
 
+                $requires_php = isset( $info['RequiresPHP'] ) ? $info['RequiresPHP'] : null;
+                $requires_wp  = isset( $info['RequiresWP'] ) ? $info['RequiresWP'] : null;
+
+                if ( ! is_php_version_compatible( $requires_php ) ) {
+                        $error = sprintf(
+                                /* translators: 1: Current PHP version, 2: Version required by the uploaded theme. */
+                                __( 'The PHP version on your server is %1$s, however the uploaded theme requires %2$s.' ),
+                                phpversion(),
+                                $requires_php
+                        );
+
+                        return new WP_Error( 'incompatible_php_required_version', $this->strings['incompatible_archive'], $error );
+                }
+                if ( ! is_wp_version_compatible( $requires_wp ) ) {
+                        $error = sprintf(
+                                /* translators: 1: Current WordPress version, 2: Version required by the uploaded theme. */
+                                __( 'Your WordPress version is %1$s, however the uploaded theme requires %2$s.' ),
+                                $GLOBALS['wp_version'],
+                                $requires_wp
+                        );
+
+                        return new WP_Error( 'incompatible_wp_required_version', $this->strings['incompatible_archive'], $error );
+                }
+
                 $this->new_theme_data = $info;
+
                 return $source;
         }