Changeset 48912 for trunk/src/wp-includes/comment-template.php

Timestamp:

08/31/2020 03:56:41 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Make sure get_the_date() and related functions return correct time if the format was specified as false.

Technically, the $format argument should always be a string, but passing false used to work before [47808], so this restores backward compatibility.

The list of affected functions:

• get_the_date()
• get_the_time()
• get_comment_date()
• get_comment_time()

Props wittich, Rarst, akabarikalpesh, SergeyBiryukov.
Fixes #51184.

File:

• trunk/src/wp-includes/comment-template.php (modified) (2 diffs)

trunk/src/wp-includes/comment-template.php

@@ -553 +553 @@
     $comment = get_comment( $comment_ID );
 
-    if ( '' === $format ) {
-        $date = mysql2date( get_option( 'date_format' ), $comment->comment_date );
-    } else {
-        $date = mysql2date( $format, $comment->comment_date );
-    }
+    if ( ! is_string( $format ) || '' === $format ) {
+        $format = get_option( 'date_format' );
+    }
+
+    $date = mysql2date( $format, $comment->comment_date );
 
     /**
@@ -1047 +1047 @@
     $comment_date = $gmt ? $comment->comment_date_gmt : $comment->comment_date;
 
-    if ( '' === $format ) {
-        $date = mysql2date( get_option( 'time_format' ), $comment_date, $translate );
-    } else {
-        $date = mysql2date( $format, $comment_date, $translate );
-    }
+    if ( ! is_string( $format ) || '' === $format ) {
+        $format = get_option( 'time_format' );
+    }
+
+    $date = mysql2date( $format, $comment_date, $translate );
 
     /**