Changeset 48937 for trunk/tests/phpunit/tests/image/editorImagick.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/image/editorImagick.php (modified) (9 diffs)

trunk/tests/phpunit/tests/image/editorImagick.php

@@ -55 +55 @@
         $imagick_image_editor->resize( 100, 50 );
 
-        $this->assertEquals(
+        $this->assertSame(
             array(
                 'width'  => 75,
@@ -92 +92 @@
         );
 
-        $this->assertEquals( $expected_array, $resized );
+        $this->assertSame( $expected_array, $resized );
 
         // Now, verify real dimensions are as expected.
@@ -364 +364 @@
 
         $this->assertNotNull( $resized );
-        $this->assertEquals( $expected_array, $resized );
+        $this->assertSame( $expected_array, $resized );
 
         foreach ( $resized as $key => $image_data ) {
@@ -389 +389 @@
         $imagick_image_editor->resize( 100, 50, true );
 
-        $this->assertEquals(
+        $this->assertSame(
             array(
                 'width'  => 100,
@@ -409 +409 @@
         $imagick_image_editor->crop( 0, 0, 50, 50 );
 
-        $this->assertEquals(
+        $this->assertSame(
             array(
                 'width'  => 50,
@@ -434 +434 @@
         $imagick_image_editor->rotate( 180 );
 
-        $this->assertEquals( $color_top_left, $property->getValue( $imagick_image_editor )->getImagePixelColor( 99, 99 )->getColor() );
+        $this->assertSame( $color_top_left, $property->getValue( $imagick_image_editor )->getImagePixelColor( 99, 99 )->getColor() );
     }
 
@@ -453 +453 @@
         $imagick_image_editor->flip( true, false );
 
-        $this->assertEquals( $color_top_left, $property->getValue( $imagick_image_editor )->getImagePixelColor( 0, 99 )->getColor() );
+        $this->assertSame( $color_top_left, $property->getValue( $imagick_image_editor )->getImagePixelColor( 0, 99 )->getColor() );
     }
 
@@ -559 +559 @@
 
         // The orientation value 3 is equivalent to rotated upside down (180 degrees).
-        $this->assertEquals( 3, intval( $data['orientation'] ), 'Orientation value read from does not match image file Exif data: ' . $file );
+        $this->assertSame( 3, intval( $data['orientation'] ), 'Orientation value read from does not match image file Exif data: ' . $file );
 
         $temp_file = wp_tempnam( $file );
@@ -571 +571 @@
 
         // Make sure the image is no longer in The Upside Down Exif orientation.
-        $this->assertEquals( 1, intval( $data['orientation'] ), 'Orientation Exif data was not updated after rotating image: ' . $file );
+        $this->assertSame( 1, intval( $data['orientation'] ), 'Orientation Exif data was not updated after rotating image: ' . $file );
 
         // Remove both the generated file ending in .tmp and tmp.jpg due to wp_tempnam().