Changeset 49724 for branches/5.6/src/wp-includes/script-loader.php

Timestamp:

12/01/2020 06:05:52 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Site Health, App Passwords: Ensure REST API responses are properly translated.

The REST API requests in Site Health and App Passwords now include _locale=user in the request URL to ensure the user's locale is used instead of the site locale. Additionally, the apiRequest library now sends a JSON Accept header which is required by determine_locale() to respect the _locale query parameter.

The Site Health REST API controllers now manually load the default admin textdomain if not is_admin(). This allows for the Site Health tests to be translated even though the translations are part of the administration project and the REST API is not.

Props oglekler, kebbet, Clorith, TimothyBlynJacobs, ocean90, SergeyBiryukov, adamsilverstein.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [49716] to the 5.6 branch.
Fixes #51871.

Location:

branches/5.6

Files:

• . (modified) (1 prop)
• src/wp-includes/script-loader.php (modified) (1 diff)

branches/5.6/src/wp-includes/script-loader.php

@@ -1287 +1287 @@
         $scripts->set_translations( 'plugin-install' );
 
-        $scripts->add( 'site-health', "/wp-admin/js/site-health$suffix.js", array( 'clipboard', 'jquery', 'wp-util', 'wp-a11y', 'wp-api-request' ), false, 1 );
+        $scripts->add( 'site-health', "/wp-admin/js/site-health$suffix.js", array( 'clipboard', 'jquery', 'wp-util', 'wp-a11y', 'wp-api-request', 'wp-url' ), false, 1 );
         $scripts->set_translations( 'site-health' );