Changeset 4990 for trunk/wp-admin/admin-functions.php

Timestamp:

03/07/2007 05:29:15 AM (19 years ago)

Author:

markjaquith

Message:

Use strpos instead of strstr where ever possible, for speed. Props rob1n. fixes #3920

File:

• trunk/wp-admin/admin-functions.php (modified) (5 diffs)

trunk/wp-admin/admin-functions.php

@@ -1144 +1144 @@
             $state = true;
             foreach ( $markerdata as $n => $markerline ) {
-                if ( strstr( $markerline, "# BEGIN {$marker}" ))
+                if (strpos($markerline, '# BEGIN ' . $marker) !== false)
                     $state = false;
                 if ( $state ) {
@@ -1152 +1152 @@
                         fwrite( $f, "{$markerline}" );
                 }
-                if ( strstr( $markerline, "# END {$marker}" ) ) {
+                if (strpos($markerline, '# END ' . $marker) !== false) {
                     fwrite( $f, "# BEGIN {$marker}\n" );
                     if ( is_array( $insertion ))
@@ -1190 +1190 @@
         $state = false;
         foreach ( $markerdata as $markerline ) {
-            if ( strstr( $markerline, "# END {$marker}" ))
+            if (strpos($markerline, '# END ' . $marker) !== false)
                 $state = false;
             if ( $state )
                 $result[] = $markerline;
-            if ( strstr( $markerline, "# BEGIN {$marker}" ))
+            if (strpos($markerline, '# BEGIN ' . $marker) !== false)
                 $state = true;
         }
@@ -1767 +1767 @@
         ';
 }
-if ( strstr( $_SERVER['HTTP_USER_AGENT'], 'MSIE' ))
+
+if (strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') !== false)
     add_action( 'admin_footer', 'browse_happy' );
 
@@ -1928 +1929 @@
     $size = strtolower( ini_get( 'upload_max_filesize' ) );
     $bytes = 0;
-    if ( strstr( $size, 'k' ) )
+    if (strpos($size, 'k') !== false)
         $bytes = $size * 1024;
-    if ( strstr( $size, 'm' ) )
+    if (strpos($size, 'm') !== false)
         $bytes = $size * 1024 * 1024;
-    if ( strstr( $size, 'g' ) )
+    if (strpos($size, 'g') !== false)
         $bytes = $size * 1024 * 1024 * 1024;
 ?>