Changeset 50393 for trunk/src/wp-includes/functions.wp-scripts.php

Timestamp:

02/20/2021 09:53:48 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Script Loader: Explicitly declare the $pagenow global in wp_deregister_script().

This avoids an "Undefined index" PHP notice in wp_resource_hints() tests when running the full test suite.

Remove the unused global from get_home_url().

Follow-up to [25443], [38100], [38174], [50156], [50164].

Props peterwilsoncc.
Fixes #52566.

File:

• trunk/src/wp-includes/functions.wp-scripts.php (modified) (2 diffs)

trunk/src/wp-includes/functions.wp-scripts.php

@@ -259 +259 @@
  * @since 2.1.0
  *
+ * @global string $pagenow
+ *
  * @param string $handle Name of the script to be removed.
  */
 function wp_deregister_script( $handle ) {
+    global $pagenow;
+
     _wp_scripts_maybe_doing_it_wrong( __FUNCTION__, $handle );
 
@@ -270 +274 @@
     $current_filter = current_filter();
     if ( ( is_admin() && 'admin_enqueue_scripts' !== $current_filter ) ||
-        ( 'wp-login.php' === $GLOBALS['pagenow'] && 'login_enqueue_scripts' !== $current_filter )
+        ( 'wp-login.php' === $pagenow && 'login_enqueue_scripts' !== $current_filter )
     ) {
         $not_allowed = array(