Changeset 51137 for trunk/tests/phpunit/tests/theme/wpThemeJson.php

Timestamp:

06/10/2021 07:18:15 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSameSets() in some newly introduced tests.

This ensures that not only the array values being compared are equal, but also that their type is the same.

Going forward, stricter type checking by using assertSameSets() or assertSameSetsWithIndex() should generally be preferred, to make the tests more reliable.

Follow-up to [48939], [49925], [50157], [50959], [50960], [50995], [51079].

See #52625.

File:

• trunk/tests/phpunit/tests/theme/wpThemeJson.php (modified) (5 diffs)

trunk/tests/phpunit/tests/theme/wpThemeJson.php

@@ -62 +62 @@
                 );
 
-                $this->assertEqualSetsWithIndex( $expected, $actual );
+                $this->assertSameSetsWithIndex( $expected, $actual );
         }
 
@@ -657 +657 @@
                 $actual   = WP_Theme_JSON::get_from_editor_settings( array() );
 
-                $this->assertEqualSetsWithIndex( $expected, $actual );
+                $this->assertSameSetsWithIndex( $expected, $actual );
         }
 
@@ -674 +674 @@
                 $actual = WP_Theme_JSON::get_from_editor_settings( $input );
 
-                $this->assertEqualSetsWithIndex( $expected, $actual['settings']['spacing'] );
+                $this->assertSameSetsWithIndex( $expected, $actual['settings']['spacing'] );
         }
 
@@ -691 +691 @@
                 $actual = WP_Theme_JSON::get_from_editor_settings( $input );
 
-                $this->assertEqualSetsWithIndex( $expected, $actual['settings']['spacing'] );
+                $this->assertSameSetsWithIndex( $expected, $actual['settings']['spacing'] );
         }
 
@@ -708 +708 @@
                 $actual = WP_Theme_JSON::get_from_editor_settings( $input );
 
-                $this->assertEqualSetsWithIndex( $expected, $actual['settings']['spacing'] );
+                $this->assertSameSetsWithIndex( $expected, $actual['settings']['spacing'] );
         }