Changeset 51216 for trunk/src/wp-includes/class-wp-widget-factory.php

Timestamp:

06/23/2021 01:33:20 AM (4 years ago)

Author:

noisysocks

Message:

Widgets: Fix widget preview not working if widget registered via a instance

The register_widget function can be called with a class name or a class
instance. Once called with a class instance, the class instance is converted to
hash as used key in array.

Props spacedmonkey, zieladam.

File:

• trunk/src/wp-includes/class-wp-widget-factory.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-widget-factory.php

@@ -113 +113 @@
      */
     public function get_widget_object( $id_base ) {
-        foreach ( $this->widgets as $widget_object ) {
+        $key = $this->get_widget_key( $id_base );
+        if ( '' === $key ) {
+            return null;
+        }
+
+        return $this->widgets[ $key ];
+    }
+
+    /**
+     * Returns the registered key for the given widget type.
+     *
+     * @since 5.8.0
+     *
+     * @param string $id_base Widget type ID.
+     * @return string
+     */
+    public function get_widget_key( $id_base ) {
+        foreach ( $this->widgets as $key => $widget_object ) {
             if ( $widget_object->id_base === $id_base ) {
-                return $widget_object;
+                return $key;
             }
         }
 
-        return null;
+        return '';
     }
 }